The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in tty_open
@ 2003-03-11 23:49 Martin J. Bligh
  2003-03-12  0:21 ` Andrew Morton
  2003-03-12  1:30 ` Alan Cox
  0 siblings, 2 replies; 4+ messages in thread
From: Martin J. Bligh @ 2003-03-11 23:49 UTC (permalink / raw)
  To: linux-kernel

I'm getting lots of these messages whilst running big SDET runs on
an 16-way machine ... anyone recognize them?
(64-bk3 + a few patches).

dev (pts(136,0)) tty->count(4) != #fd's(3) in release_dev
Warning: dev (pts(136,0)) tty->count(4) != #fd's(3) in tty_open
Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in tty_open
Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in release_dev
Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in tty_open
Warning: dev (pts(136,0)) tty->count(6) != #fd's(5) in tty_open
Warning: dev (pts(136,0)) tty->count(7) != #fd's(6) in tty_open
Warning: dev (pts(136,0)) tty->count(8) != #fd's(7) in tty_open
Warning: dev (pts(136,0)) tty->count(9) != #fd's(8) in tty_open
Warning: dev (pts(136,0)) tty->count(10) != #fd's(9) in tty_open
Warning: dev (pts(136,0)) tty->count(11) != #fd's(10) in tty_open
Warning: dev (pts(136,0)) tty->count(12) != #fd's(11) in tty_open
Warning: dev (pts(136,0)) tty->count(13) != #fd's(12) in tty_open
Warning: dev (pts(136,0)) tty->count(14) != #fd's(13) in tty_open
Warning: dev (pts(136,0)) tty->count(15) != #fd's(14) in tty_open
Warning: dev (pts(136,0)) tty->count(16) != #fd's(15) in tty_open
Warning: dev (pts(136,0)) tty->count(17) != #fd's(16) in tty_open
Warning: dev (pts(136,0)) tty->count(18) != #fd's(17) in tty_open
Warning: dev (pts(136,0)) tty->count(18) != #fd's(17) in release_dev
Warning: dev (pts(136,0)) tty->count(18) != #fd's(17) in tty_open
Warning: dev (pts(136,0)) tty->count(19) != #fd's(18) in tty_open
Warning: dev (pts(136,0)) tty->count(20) != #fd's(19) in tty_open
Warning: dev (pts(136,0)) tty->count(21) != #fd's(20) in tty_open
Warning: dev (pts(136,0)) tty->count(22) != #fd's(21) in tty_open
Warning: dev (pts(136,0)) tty->count(23) != #fd's(22) in tty_open
Warning: dev (pts(136,0)) tty->count(23) != #fd's(22) in release_dev
Warning: dev (pts(136,0)) tty->count(22) != #fd's(21) in release_dev
Warning: dev (pts(136,0)) tty->count(21) != #fd's(20) in release_dev
Warning: dev (pts(136,0)) tty->count(21) != #fd's(20) in tty_open
Warning: dev (pts(136,0)) tty->count(22) != #fd's(21) in tty_open
Warning: dev (pts(136,0)) tty->count(23) != #fd's(22) in tty_open
Warning: dev (pts(136,0)) tty->count(23) != #fd's(22) in release_dev
Warning: dev (pts(136,0)) tty->count(22) != #fd's(21) in release_dev
Warning: dev (pts(136,0)) tty->count(22) != #fd's(21) in tty_open
Warning: dev (pts(136,0)) tty->count(22) != #fd's(21) in release_dev
Warning: dev (pts(136,0)) tty->count(21) != #fd's(20) in release_dev
Warning: dev (pts(136,0)) tty->count(20) != #fd's(19) in release_dev
Warning: dev (pts(136,0)) tty->count(20) != #fd's(19) in tty_open
Warning: dev (pts(136,0)) tty->count(21) != #fd's(20) in tty_open
Warning: dev (pts(136,0)) tty->count(22) != #fd's(21) in tty_open
Warning: dev (pts(136,0)) tty->count(22) != #fd's(21) in release_dev
Warning: dev (pts(136,0)) tty->count(21) != #fd's(20) in release_dev
Warning: dev (pts(136,0)) tty->count(20) != #fd's(19) in release_dev
Warning: dev (pts(136,0)) tty->count(19) != #fd's(18) in release_dev
Warning: dev (pts(136,0)) tty->count(18) != #fd's(17) in release_dev
Warning: dev (pts(136,0)) tty->count(17) != #fd's(16) in release_dev
Warning: dev (pts(136,0)) tty->count(16) != #fd's(15) in release_dev
Warning: dev (pts(136,0)) tty->count(15) != #fd's(14) in release_dev
Warning: dev (pts(136,0)) tty->count(14) != #fd's(13) in release_dev
Warning: dev (pts(136,0)) tty->count(13) != #fd's(12) in release_dev
Warning: dev (pts(136,0)) tty->count(12) != #fd's(11) in release_dev
Warning: dev (pts(136,0)) tty->count(12) != #fd's(11) in tty_open
Warning: dev (pts(136,0)) tty->count(12) != #fd's(11) in release_dev
Warning: dev (pts(136,0)) tty->count(11) != #fd's(3) in release_dev
Warning: dev (pts(136,0)) tty->count(10) != #fd's(3) in release_dev
Warning: dev (pts(136,0)) tty->count(9) != #fd's(3) in release_dev
Warning: dev (pts(136,0)) tty->count(9) != #fd's(4) in tty_open
Warning: dev (pts(136,0)) tty->count(9) != #fd's(4) in release_dev
Warning: dev (pts(136,0)) tty->count(9) != #fd's(5) in tty_open
Warning: dev (pts(136,0)) tty->count(10) != #fd's(6) in tty_open
Warning: dev (pts(136,0)) tty->count(11) != #fd's(7) in tty_open



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in tty_open
  2003-03-11 23:49 Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in tty_open Martin J. Bligh
@ 2003-03-12  0:21 ` Andrew Morton
  2003-03-12  0:29   ` Martin J. Bligh
  2003-03-12  1:30 ` Alan Cox
  1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2003-03-12  0:21 UTC (permalink / raw)
  To: Martin J. Bligh; +Cc: linux-kernel

"Martin J. Bligh" <mbligh@aracnet.com> wrote:
>
> I'm getting lots of these messages whilst running big SDET runs on
> an 16-way machine ... anyone recognize them?
> (64-bk3 + a few patches).
> 
> dev (pts(136,0)) tty->count(4) != #fd's(3) in release_dev

The file_list_lock patches affect this.  Do you have those applied?

If so, and if it is repeatable, this might help.  (Unlikely, but it might).


diff -puN drivers/char/tty_io.c~tty_files-fixes drivers/char/tty_io.c
--- 25/drivers/char/tty_io.c~tty_files-fixes	2003-03-09 23:15:15.000000000 -0800
+++ 25-akpm/drivers/char/tty_io.c	2003-03-09 23:15:58.000000000 -0800
@@ -1037,7 +1037,9 @@ static void release_mem(struct tty_struc
 		}
 		o_tty->magic = 0;
 		(*o_tty->driver.refcount)--;
+		file_list_lock();
 		list_del(&o_tty->tty_files);
+		file_list_unlock();
 		free_tty_struct(o_tty);
 	}
 
@@ -1049,7 +1051,9 @@ static void release_mem(struct tty_struc
 	}
 	tty->magic = 0;
 	(*tty->driver.refcount)--;
+	file_list_lock();
 	list_del(&tty->tty_files);
+	file_list_unlock();
 	module_put(tty->driver.owner);
 	free_tty_struct(tty);
 }

_


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in tty_open
  2003-03-12  0:21 ` Andrew Morton
@ 2003-03-12  0:29   ` Martin J. Bligh
  0 siblings, 0 replies; 4+ messages in thread
From: Martin J. Bligh @ 2003-03-12  0:29 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

>> I'm getting lots of these messages whilst running big SDET runs on
>> an 16-way machine ... anyone recognize them?
>> (64-bk3 + a few patches).
>> 
>> dev (pts(136,0)) tty->count(4) != #fd's(3) in release_dev
> 
> The file_list_lock patches affect this.  Do you have those applied?

Yes, sorry ... was running out the door, crap description ;-)
 
> If so, and if it is repeatable, this might help.  (Unlikely, but it might).

Mmm ... OK. will try that. Thanks,

M.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in tty_open
  2003-03-11 23:49 Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in tty_open Martin J. Bligh
  2003-03-12  0:21 ` Andrew Morton
@ 2003-03-12  1:30 ` Alan Cox
  1 sibling, 0 replies; 4+ messages in thread
From: Alan Cox @ 2003-03-12  1:30 UTC (permalink / raw)
  To: Martin J. Bligh; +Cc: Linux Kernel Mailing List

On Tue, 2003-03-11 at 23:49, Martin J. Bligh wrote:
> I'm getting lots of these messages whilst running big SDET runs on
> an 16-way machine ... anyone recognize them?
> (64-bk3 + a few patches).
> 
> dev (pts(136,0)) tty->count(4) != #fd's(3) in release_dev
> Warning: dev (pts(136,0)) tty->count(4) != #fd's(3) in tty_open
> Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in tty_open
> Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in release_dev

These are some of the things I saw when reporting the tty races and
doing zillions of open/closes on pty/tty pairs. The tty layer has
some fun code dealing with open v close v hangup v vhangup


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2003-03-12  0:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-11 23:49 Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in tty_open Martin J. Bligh
2003-03-12  0:21 ` Andrew Morton
2003-03-12  0:29   ` Martin J. Bligh
2003-03-12  1:30 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox