* [PATCH] x86-64: also define AT_VECTOR_SIZE_ARCH
@ 2007-12-10 15:42 Jan Beulich
2007-12-17 13:42 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2007-12-10 15:42 UTC (permalink / raw)
To: mingo; +Cc: olaf, linux-kernel
The patch introducing this left out x86-64, despite it also having
extra entries.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Olaf Hering <olaf@aepfle.de>
include/asm-x86/system_64.h | 6 ++++++
1 file changed, 6 insertions(+)
--- linux-2.6.24-rc4/include/asm-x86/system_64.h 2007-12-10 16:11:42.000000000 +0100
+++ 2.6.24-rc4-x86_64-at-vector-size/include/asm-x86/system_64.h 2007-12-04 16:09:33.000000000 +0100
@@ -7,6 +7,12 @@
#ifdef __KERNEL__
+#ifdef CONFIG_IA32_EMULATION
+#define AT_VECTOR_SIZE_ARCH 2
+#else
+#define AT_VECTOR_SIZE_ARCH 1
+#endif
+
#define __SAVE(reg,offset) "movq %%" #reg ",(14-" #offset ")*8(%%rsp)\n\t"
#define __RESTORE(reg,offset) "movq (14-" #offset ")*8(%%rsp),%%" #reg "\n\t"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86-64: also define AT_VECTOR_SIZE_ARCH
2007-12-10 15:42 [PATCH] x86-64: also define AT_VECTOR_SIZE_ARCH Jan Beulich
@ 2007-12-17 13:42 ` Ingo Molnar
2007-12-17 13:53 ` Jan Beulich
0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2007-12-17 13:42 UTC (permalink / raw)
To: Jan Beulich
Cc: mingo, olaf, linux-kernel, Thomas Gleixner, H. Peter Anvin,
Andrew Morton
* Jan Beulich <jbeulich@novell.com> wrote:
> The patch introducing this left out x86-64, despite it also having
> extra entries.
thanks, applied. Is there any 2.6.24 urgency for this?
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86-64: also define AT_VECTOR_SIZE_ARCH
2007-12-17 13:42 ` Ingo Molnar
@ 2007-12-17 13:53 ` Jan Beulich
2007-12-17 13:55 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2007-12-17 13:53 UTC (permalink / raw)
To: Ingo Molnar
Cc: olaf, Thomas Gleixner, Andrew Morton, mingo, linux-kernel,
H. Peter Anvin
>>> Ingo Molnar <mingo@elte.hu> 17.12.07 14:42 >>>
>
>* Jan Beulich <jbeulich@novell.com> wrote:
>
>> The patch introducing this left out x86-64, despite it also having
>> extra entries.
>
>thanks, applied. Is there any 2.6.24 urgency for this?
While I haven't seen x86-64 to break due to this (it appears that 32-bit
apps would be more susceptible), I know that we had major problems
with the respective piece missing from the 32-bit Xen kernels in openSuSE
10.3, so I would strongly suggest putting this into .24.
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86-64: also define AT_VECTOR_SIZE_ARCH
2007-12-17 13:53 ` Jan Beulich
@ 2007-12-17 13:55 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2007-12-17 13:55 UTC (permalink / raw)
To: Jan Beulich
Cc: olaf, Thomas Gleixner, Andrew Morton, mingo, linux-kernel,
H. Peter Anvin
* Jan Beulich <jbeulich@novell.com> wrote:
> >>> Ingo Molnar <mingo@elte.hu> 17.12.07 14:42 >>>
> >
> >* Jan Beulich <jbeulich@novell.com> wrote:
> >
> >> The patch introducing this left out x86-64, despite it also having
> >> extra entries.
> >
> >thanks, applied. Is there any 2.6.24 urgency for this?
>
> While I haven't seen x86-64 to break due to this (it appears that
> 32-bit apps would be more susceptible), I know that we had major
> problems with the respective piece missing from the 32-bit Xen kernels
> in openSuSE 10.3, so I would strongly suggest putting this into .24.
ok, queued it up for the next push.
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-12-17 13:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-10 15:42 [PATCH] x86-64: also define AT_VECTOR_SIZE_ARCH Jan Beulich
2007-12-17 13:42 ` Ingo Molnar
2007-12-17 13:53 ` Jan Beulich
2007-12-17 13:55 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox