* [PATCH 6/7] drivers/net/ipg.c: remove unused variable
@ 2008-03-15 16:04 Julia Lawall
2008-03-17 11:58 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2008-03-15 16:04 UTC (permalink / raw)
To: jesse, jgarzik, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The variable gig is initialized but never used otherwise.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
identifier i;
constant C;
@@
(
extern T i;
|
- T i;
<+... when != i
- i = C;
...+>
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/ipg.c | 3 ---
1 file changed, 3 deletions(-)
diff -u -p a/drivers/net/ipg.c b/drivers/net/ipg.c
--- a/drivers/net/ipg.c 2008-03-12 14:13:13.000000000 +0100
+++ b/drivers/net/ipg.c 2008-03-15 11:17:14.000000000 +0100
@@ -472,7 +472,6 @@ static int ipg_config_autoneg(struct net
unsigned int txflowcontrol;
unsigned int rxflowcontrol;
unsigned int fullduplex;
- unsigned int gig;
u32 mac_ctrl_val;
u32 asicctrl;
u8 phyctrl;
@@ -489,7 +488,6 @@ static int ipg_config_autoneg(struct net
fullduplex = 0;
txflowcontrol = 0;
rxflowcontrol = 0;
- gig = 0;
/* To accomodate a problem in 10Mbps operation,
* set a global flag if PHY running in 10Mbps mode.
@@ -511,7 +509,6 @@ static int ipg_config_autoneg(struct net
break;
case IPG_PC_LINK_SPEED_1000MBPS:
printk("1000Mbps.\n");
- gig = 1;
break;
default:
printk("undefined!\n");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 6/7] drivers/net/ipg.c: remove unused variable
2008-03-15 16:04 [PATCH 6/7] drivers/net/ipg.c: remove unused variable Julia Lawall
@ 2008-03-17 11:58 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-03-17 11:58 UTC (permalink / raw)
To: Julia Lawall; +Cc: jesse, linux-kernel, kernel-janitors
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The variable gig is initialized but never used otherwise.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> type T;
> identifier i;
> constant C;
> @@
>
> (
> extern T i;
> |
> - T i;
> <+... when != i
> - i = C;
> ...+>
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
> ---
> drivers/net/ipg.c | 3 ---
> 1 file changed, 3 deletions(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-17 11:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-15 16:04 [PATCH 6/7] drivers/net/ipg.c: remove unused variable Julia Lawall
2008-03-17 11:58 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox