public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* linux-next: Tree for March 31
@ 2008-03-31  7:11 Stephen Rothwell
  2008-03-31 11:19 ` [BUILD_FAILURE] linux-next: Tree for March 31 build fails on fs/novfs sys_flistxattr() Kamalesh Babulal
  2008-03-31 13:17 ` [BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y Kamalesh Babulal
  0 siblings, 2 replies; 8+ messages in thread
From: Stephen Rothwell @ 2008-03-31  7:11 UTC (permalink / raw)
  To: linux-next; +Cc: LKML

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

Hi all,

I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git
(tar balls at
http://www.kernel.org/pub/linux/kernel/people/sfr/linux-next/).

You can see which trees have been included by looking in the Next/Trees
file in the source.  There are also quilt-import.log and merge.log files
in the Next directory.  Between each merge, the tree was built with
a ppc64_defconfig for powerpc and an allmodconfig for x86_64.

There were a few merge conflicts (fairly trivial).  Most new ones were
from Al Viro's NULL sparse complaint cleanups.

We are up to 50 trees, more are welcome (even if they are currently
empty).  Thanks to those who have contributed, and to those who haven't,
please do.

In particular, I have very few of the architecture trees ....

Status of my local build tests is at
http://kisskb.ellerman.id.au/linux-next.  If maintainers want to give
advice about cross compilers/configs that work, we are always open to add
more builds.

Thanks to Jan Dittmer for adding the linux-next tree to his build tests
at http://l4x.org/k/ and the guys at http://test.kernel.org/.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [BUILD_FAILURE] linux-next: Tree for March 31 build fails on fs/novfs sys_flistxattr()
  2008-03-31  7:11 linux-next: Tree for March 31 Stephen Rothwell
@ 2008-03-31 11:19 ` Kamalesh Babulal
  2008-03-31 11:41   ` Stephen Rothwell
  2008-03-31 13:17 ` [BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y Kamalesh Babulal
  1 sibling, 1 reply; 8+ messages in thread
From: Kamalesh Babulal @ 2008-03-31 11:19 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, LKML, Andy Whitcroft

Hi Stephen,

The next-20080331 allyesconfig, build fails on x86_64 machine

fs/novfs/built-in.o: In function `sys_flistxattr':
/root/kernels/linux-2.6.25-rc7/fs/novfs/inode.c:4658: multiple definition of `sys_flistxattr'
fs/xattr.o:/root/kernels/linux-2.6.25-rc7/fs/xattr.c:457: first defined here
ld: Warning: size of symbol `sys_flistxattr' changed from 112 in fs/xattr.o to 75 in fs/novfs/built-in.o
fs/novfs/built-in.o: In function `sys_fsetxattr':
/root/kernels/linux-2.6.25-rc7/fs/novfs/inode.c:4672: multiple definition of `sys_fsetxattr'
fs/xattr.o:/root/kernels/linux-2.6.25-rc7/fs/xattr.c:295: first defined here
ld: Warning: size of symbol `sys_fsetxattr' changed from 164 in fs/xattr.o to 97 in fs/novfs/built-in.o
fs/novfs/built-in.o: In function `sys_fgetxattr':
/root/kernels/linux-2.6.25-rc7/fs/novfs/inode.c:4645: multiple definition of `sys_fgetxattr'
fs/xattr.o:/root/kernels/linux-2.6.25-rc7/fs/xattr.c:384: first defined here
ld: Warning: size of symbol `sys_fgetxattr' changed from 128 in fs/xattr.o to 91 in fs/novfs/built-in.o
make[1]: *** [fs/built-in.o] Error 1
make: *** [fs] Error 2


-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [BUILD_FAILURE] linux-next: Tree for March 31 build fails on fs/novfs sys_flistxattr()
  2008-03-31 11:19 ` [BUILD_FAILURE] linux-next: Tree for March 31 build fails on fs/novfs sys_flistxattr() Kamalesh Babulal
@ 2008-03-31 11:41   ` Stephen Rothwell
  2008-03-31 15:54     ` Greg KH
  2008-03-31 16:50     ` Greg KH
  0 siblings, 2 replies; 8+ messages in thread
From: Stephen Rothwell @ 2008-03-31 11:41 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, LKML, Andy Whitcroft, Kamalesh Babulal,
	Lonnie Iverson

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

On Mon, 31 Mar 2008 16:49:18 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> Hi Stephen,
> 
> The next-20080331 allyesconfig, build fails on x86_64 machine
> 
> fs/novfs/built-in.o: In function `sys_flistxattr':
> /root/kernels/linux-2.6.25-rc7/fs/novfs/inode.c:4658: multiple definition of `sys_flistxattr'
> fs/xattr.o:/root/kernels/linux-2.6.25-rc7/fs/xattr.c:457: first defined here
> ld: Warning: size of symbol `sys_flistxattr' changed from 112 in fs/xattr.o to 75 in fs/novfs/built-in.o
> fs/novfs/built-in.o: In function `sys_fsetxattr':
> /root/kernels/linux-2.6.25-rc7/fs/novfs/inode.c:4672: multiple definition of `sys_fsetxattr'
> fs/xattr.o:/root/kernels/linux-2.6.25-rc7/fs/xattr.c:295: first defined here
> ld: Warning: size of symbol `sys_fsetxattr' changed from 164 in fs/xattr.o to 97 in fs/novfs/built-in.o
> fs/novfs/built-in.o: In function `sys_fgetxattr':
> /root/kernels/linux-2.6.25-rc7/fs/novfs/inode.c:4645: multiple definition of `sys_fgetxattr'
> fs/xattr.o:/root/kernels/linux-2.6.25-rc7/fs/xattr.c:384: first defined here
> ld: Warning: size of symbol `sys_fgetxattr' changed from 128 in fs/xattr.o to 91 in fs/novfs/built-in.o
> make[1]: *** [fs/built-in.o] Error 1
> make: *** [fs] Error 2

Yes, well this from fs/novfs/inode.c was asking for it really :-)

asmlinkage ssize_t sys_flistxattr(int fd, char __user * list, size_t size)
{
.
.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y
  2008-03-31  7:11 linux-next: Tree for March 31 Stephen Rothwell
  2008-03-31 11:19 ` [BUILD_FAILURE] linux-next: Tree for March 31 build fails on fs/novfs sys_flistxattr() Kamalesh Babulal
@ 2008-03-31 13:17 ` Kamalesh Babulal
  2008-03-31 13:31   ` Stephen Rothwell
  1 sibling, 1 reply; 8+ messages in thread
From: Kamalesh Babulal @ 2008-03-31 13:17 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, LKML, netdev, Andy Whitcroft

Hi Stephen,

The kernel next-20080331 kernel build fails with Alacritech's IS-NIC gigabit ethernet
driver on powerpc with allyesconfig (with # CONFIG_NOVFS is not set)

  CC      drivers/net/slicoss/slicoss.o
drivers/net/slicoss/slicoss.c: In function ‘slic_xmit_build_request’:
drivers/net/slicoss/slicoss.c:933: error: ‘Stop’ undeclared (first use in this function)
drivers/net/slicoss/slicoss.c:933: error: (Each undeclared identifier is reported only once
drivers/net/slicoss/slicoss.c:933: error: for each function it appears in.)
drivers/net/slicoss/slicoss.c:933: error: expected ‘;’ before ‘Compilation’
drivers/net/slicoss/slicoss.c: In function ‘slic_link_event_handler’:
drivers/net/slicoss/slicoss.c:1420: error: ‘Stop’ undeclared (first use in this function)
drivers/net/slicoss/slicoss.c:1420: error: expected ‘;’ before ‘compilation’
drivers/net/slicoss/slicoss.c: In function ‘slic_if_init’:
drivers/net/slicoss/slicoss.c:1848: error: ‘Stop’ undeclared (first use in this function)
drivers/net/slicoss/slicoss.c:1848: error: expected ‘;’ before ‘Compilations’
drivers/net/slicoss/slicoss.c: In function ‘slic_card_init’:
drivers/net/slicoss/slicoss.c:2518: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_timer_get_stats’:
drivers/net/slicoss/slicoss.c:3269: error: ‘Stop’ undeclared (first use in this function)
drivers/net/slicoss/slicoss.c:3269: error: expected ‘;’ before ‘compilation’
drivers/net/slicoss/slicoss.c: In function ‘slic_link_upr_complete’:
drivers/net/slicoss/slicoss.c:3683: error: ‘Stop’ undeclared (first use in this function)
drivers/net/slicoss/slicoss.c:3683: error: expected ‘;’ before ‘Compilation’
drivers/net/slicoss/slicoss.c: In function ‘slic_eeprom_cksum’:
drivers/net/slicoss/slicoss.c:3806: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_rspqueue_init’:
drivers/net/slicoss/slicoss.c:3901: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:3901: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_rspqueue_getnext’:
drivers/net/slicoss/slicoss.c:3990: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:3990: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4004: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4004: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4009: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4009: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_cmdqmem_addpage’:
drivers/net/slicoss/slicoss.c:4056: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4056: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_init’:
drivers/net/slicoss/slicoss.c:4081: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4081: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_addcmdpage’:
drivers/net/slicoss/slicoss.c:4184: error: implicit declaration of function ‘virt_to_bus’
drivers/net/slicoss/slicoss.c:4224: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4224: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4230: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4230: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_getdone’:
drivers/net/slicoss/slicoss.c:4271: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4271: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_putdone’:
drivers/net/slicoss/slicoss.c:4287: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4287: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4289: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4289: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_putdone_irq’:
drivers/net/slicoss/slicoss.c:4301: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4301: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4303: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4303: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_rcvqueue_fill’:
drivers/net/slicoss/slicoss.c:4425: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_rcvqueue_reinsert’:
drivers/net/slicoss/slicoss.c:4504: warning: cast from pointer to integer of different size
make[3]: *** [drivers/net/slicoss/slicoss.o] Error 1
make[2]: *** [drivers/net/slicoss] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2



-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y
  2008-03-31 13:17 ` [BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y Kamalesh Babulal
@ 2008-03-31 13:31   ` Stephen Rothwell
  2008-03-31 15:55     ` Greg KH
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2008-03-31 13:31 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-next, LKML, netdev, Andy Whitcroft, Christopher Harrer,
	Kamalesh Babulal

[-- Attachment #1: Type: text/plain, Size: 6226 bytes --]

Hi Greg,

On Mon, 31 Mar 2008 18:47:10 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> The kernel next-20080331 kernel build fails with Alacritech's IS-NIC gigabit ethernet
> driver on powerpc with allyesconfig (with # CONFIG_NOVFS is not set)
> 
>   CC      drivers/net/slicoss/slicoss.o
> drivers/net/slicoss/slicoss.c: In function ‘slic_xmit_build_request’:
> drivers/net/slicoss/slicoss.c:933: error: ‘Stop’ undeclared (first use in this function)
> drivers/net/slicoss/slicoss.c:933: error: (Each undeclared identifier is reported only once
> drivers/net/slicoss/slicoss.c:933: error: for each function it appears in.)
> drivers/net/slicoss/slicoss.c:933: error: expected ‘;’ before ‘Compilation’
> drivers/net/slicoss/slicoss.c: In function ‘slic_link_event_handler’:
> drivers/net/slicoss/slicoss.c:1420: error: ‘Stop’ undeclared (first use in this function)
> drivers/net/slicoss/slicoss.c:1420: error: expected ‘;’ before ‘compilation’
> drivers/net/slicoss/slicoss.c: In function ‘slic_if_init’:
> drivers/net/slicoss/slicoss.c:1848: error: ‘Stop’ undeclared (first use in this function)
> drivers/net/slicoss/slicoss.c:1848: error: expected ‘;’ before ‘Compilations’
> drivers/net/slicoss/slicoss.c: In function ‘slic_card_init’:
> drivers/net/slicoss/slicoss.c:2518: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_timer_get_stats’:
> drivers/net/slicoss/slicoss.c:3269: error: ‘Stop’ undeclared (first use in this function)
> drivers/net/slicoss/slicoss.c:3269: error: expected ‘;’ before ‘compilation’
> drivers/net/slicoss/slicoss.c: In function ‘slic_link_upr_complete’:
> drivers/net/slicoss/slicoss.c:3683: error: ‘Stop’ undeclared (first use in this function)
> drivers/net/slicoss/slicoss.c:3683: error: expected ‘;’ before ‘Compilation’
> drivers/net/slicoss/slicoss.c: In function ‘slic_eeprom_cksum’:
> drivers/net/slicoss/slicoss.c:3806: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_rspqueue_init’:
> drivers/net/slicoss/slicoss.c:3901: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:3901: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_rspqueue_getnext’:
> drivers/net/slicoss/slicoss.c:3990: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:3990: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4004: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4004: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4009: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4009: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_cmdqmem_addpage’:
> drivers/net/slicoss/slicoss.c:4056: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4056: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_init’:
> drivers/net/slicoss/slicoss.c:4081: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4081: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_addcmdpage’:
> drivers/net/slicoss/slicoss.c:4184: error: implicit declaration of function ‘virt_to_bus’
> drivers/net/slicoss/slicoss.c:4224: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4224: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4230: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4230: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_getdone’:
> drivers/net/slicoss/slicoss.c:4271: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4271: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_putdone’:
> drivers/net/slicoss/slicoss.c:4287: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4287: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4289: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4289: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_putdone_irq’:
> drivers/net/slicoss/slicoss.c:4301: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4301: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4303: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4303: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_rcvqueue_fill’:
> drivers/net/slicoss/slicoss.c:4425: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_rcvqueue_reinsert’:
> drivers/net/slicoss/slicoss.c:4504: warning: cast from pointer to integer of different size

Strike two!  Again, these drivers need to build (or not try to build) for
all architectures ... Its out until you tell me the above is true.

#if defined(CONFIG_X86_64)
        hcmd->cmdsize = (ulong32) ((((ulong64) & ihcmd->u.slic_buffers.bufs[1] -
                                     (ulong64) hcmd) + 31) >> 5);
#elif defined(CONFIG_X86)
        hcmd->cmdsize = ((((ulong32) & ihcmd->u.slic_buffers.bufs[1] -
                           (ulong32) hcmd) + 31) >> 5);
#else
        Stop Compilation;
#endif

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [BUILD_FAILURE] linux-next: Tree for March 31 build fails on fs/novfs sys_flistxattr()
  2008-03-31 11:41   ` Stephen Rothwell
@ 2008-03-31 15:54     ` Greg KH
  2008-03-31 16:50     ` Greg KH
  1 sibling, 0 replies; 8+ messages in thread
From: Greg KH @ 2008-03-31 15:54 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, LKML, Andy Whitcroft, Kamalesh Babulal,
	Lonnie Iverson

On Mon, Mar 31, 2008 at 10:41:25PM +1100, Stephen Rothwell wrote:
> On Mon, 31 Mar 2008 16:49:18 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
> >
> > Hi Stephen,
> > 
> > The next-20080331 allyesconfig, build fails on x86_64 machine
> > 
> > fs/novfs/built-in.o: In function `sys_flistxattr':
> > /root/kernels/linux-2.6.25-rc7/fs/novfs/inode.c:4658: multiple definition of `sys_flistxattr'
> > fs/xattr.o:/root/kernels/linux-2.6.25-rc7/fs/xattr.c:457: first defined here
> > ld: Warning: size of symbol `sys_flistxattr' changed from 112 in fs/xattr.o to 75 in fs/novfs/built-in.o
> > fs/novfs/built-in.o: In function `sys_fsetxattr':
> > /root/kernels/linux-2.6.25-rc7/fs/novfs/inode.c:4672: multiple definition of `sys_fsetxattr'
> > fs/xattr.o:/root/kernels/linux-2.6.25-rc7/fs/xattr.c:295: first defined here
> > ld: Warning: size of symbol `sys_fsetxattr' changed from 164 in fs/xattr.o to 97 in fs/novfs/built-in.o
> > fs/novfs/built-in.o: In function `sys_fgetxattr':
> > /root/kernels/linux-2.6.25-rc7/fs/novfs/inode.c:4645: multiple definition of `sys_fgetxattr'
> > fs/xattr.o:/root/kernels/linux-2.6.25-rc7/fs/xattr.c:384: first defined here
> > ld: Warning: size of symbol `sys_fgetxattr' changed from 128 in fs/xattr.o to 91 in fs/novfs/built-in.o
> > make[1]: *** [fs/built-in.o] Error 1
> > make: *** [fs] Error 2
> 
> Yes, well this from fs/novfs/inode.c was asking for it really :-)
> 
> asmlinkage ssize_t sys_flistxattr(int fd, char __user * list, size_t size)
> {
> .
> .

Ugh, tha's horrible.  I'll fix that up, sorry.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y
  2008-03-31 13:31   ` Stephen Rothwell
@ 2008-03-31 15:55     ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2008-03-31 15:55 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, LKML, netdev, Andy Whitcroft, Christopher Harrer,
	Kamalesh Babulal

On Tue, Apr 01, 2008 at 12:31:10AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> Strike two!  Again, these drivers need to build (or not try to build) for
> all architectures ... Its out until you tell me the above is true.
> 
> #if defined(CONFIG_X86_64)
>         hcmd->cmdsize = (ulong32) ((((ulong64) & ihcmd->u.slic_buffers.bufs[1] -
>                                      (ulong64) hcmd) + 31) >> 5);
> #elif defined(CONFIG_X86)
>         hcmd->cmdsize = ((((ulong32) & ihcmd->u.slic_buffers.bufs[1] -
>                            (ulong32) hcmd) + 31) >> 5);
> #else
>         Stop Compilation;

Ah, missed that one, that's why it built on my machines (x86-64 and
i386), but would die on anything else.  That test is just wrong, I'll
fix it up to get it to build on all arches (doesn't mean it will run
though, it assumes that port io is memory mapped flat on all machines
and still needs a lot of work to be fixed.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [BUILD_FAILURE] linux-next: Tree for March 31 build fails on fs/novfs sys_flistxattr()
  2008-03-31 11:41   ` Stephen Rothwell
  2008-03-31 15:54     ` Greg KH
@ 2008-03-31 16:50     ` Greg KH
  1 sibling, 0 replies; 8+ messages in thread
From: Greg KH @ 2008-03-31 16:50 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, LKML, Andy Whitcroft, Kamalesh Babulal,
	Lonnie Iverson

On Mon, Mar 31, 2008 at 10:41:25PM +1100, Stephen Rothwell wrote:
> On Mon, 31 Mar 2008 16:49:18 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
> >
> > Hi Stephen,
> > 
> > The next-20080331 allyesconfig, build fails on x86_64 machine
> > 
> > fs/novfs/built-in.o: In function `sys_flistxattr':
> > /root/kernels/linux-2.6.25-rc7/fs/novfs/inode.c:4658: multiple definition of `sys_flistxattr'
> > fs/xattr.o:/root/kernels/linux-2.6.25-rc7/fs/xattr.c:457: first defined here
> > ld: Warning: size of symbol `sys_flistxattr' changed from 112 in fs/xattr.o to 75 in fs/novfs/built-in.o
> > fs/novfs/built-in.o: In function `sys_fsetxattr':
> > /root/kernels/linux-2.6.25-rc7/fs/novfs/inode.c:4672: multiple definition of `sys_fsetxattr'
> > fs/xattr.o:/root/kernels/linux-2.6.25-rc7/fs/xattr.c:295: first defined here
> > ld: Warning: size of symbol `sys_fsetxattr' changed from 164 in fs/xattr.o to 97 in fs/novfs/built-in.o
> > fs/novfs/built-in.o: In function `sys_fgetxattr':
> > /root/kernels/linux-2.6.25-rc7/fs/novfs/inode.c:4645: multiple definition of `sys_fgetxattr'
> > fs/xattr.o:/root/kernels/linux-2.6.25-rc7/fs/xattr.c:384: first defined here
> > ld: Warning: size of symbol `sys_fgetxattr' changed from 128 in fs/xattr.o to 91 in fs/novfs/built-in.o
> > make[1]: *** [fs/built-in.o] Error 1
> > make: *** [fs] Error 2
> 
> Yes, well this from fs/novfs/inode.c was asking for it really :-)
> 
> asmlinkage ssize_t sys_flistxattr(int fd, char __user * list, size_t size)
> {
> .

Now fixed up, sorry for the noise.  Why it was ever declaring it's own
system calls for extended attributes, I'll never know...

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2008-03-31 16:57 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-31  7:11 linux-next: Tree for March 31 Stephen Rothwell
2008-03-31 11:19 ` [BUILD_FAILURE] linux-next: Tree for March 31 build fails on fs/novfs sys_flistxattr() Kamalesh Babulal
2008-03-31 11:41   ` Stephen Rothwell
2008-03-31 15:54     ` Greg KH
2008-03-31 16:50     ` Greg KH
2008-03-31 13:17 ` [BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y Kamalesh Babulal
2008-03-31 13:31   ` Stephen Rothwell
2008-03-31 15:55     ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox