[PATCH V4] dt-bindings: serial: Add a new compatible string for UMS9632

[PATCH V4] dt-bindings: serial: Add a new compatible string for UMS9632

[Wenhua Lin]

The UART IP version of the ums9632 SoC project has been upgraded.
UART controller registers have added valid bits to support new features.
In order to distinguish different UART IP versions, we use sc9632-uart
to represent upgraded IP and sc9836-uart to represent old IP.

Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
---
V3->V4 changes:
* Modify the indentation format.

V2->V3 changes:
* Lists are ordered by fallback.
* Combine two const items into enum.
* Change commit message.

V1->V2 changes:
* Modify the compatible string of enum.
* Change commit message.
---
 Documentation/devicetree/bindings/serial/sprd-uart.yaml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
index a2a5056eba04..5bf2656afcfd 100644
--- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
@@ -17,13 +17,18 @@ properties:
     oneOf:
       - items:
           - enum:
-              - sprd,sc9632-uart
+              - sprd,ums9632-uart
+          - const: sprd,sc9632-uart
+      - items:
+          - enum:
               - sprd,sc9860-uart
               - sprd,sc9863a-uart
               - sprd,ums512-uart
               - sprd,ums9620-uart
           - const: sprd,sc9836-uart
-      - const: sprd,sc9836-uart
+      - enum:
+          - sprd,sc9632-uart
+          - sprd,sc9836-uart
 
   reg:
     maxItems: 1
-- 
2.34.1

Re: [PATCH V4] dt-bindings: serial: Add a new compatible string for UMS9632

[Krzysztof Kozlowski]

On 22/01/2025 08:23, Wenhua Lin wrote:
> The UART IP version of the ums9632 SoC project has been upgraded.
> UART controller registers have added valid bits to support new features.
> In order to distinguish different UART IP versions, we use sc9632-uart
> to represent upgraded IP and sc9836-uart to represent old IP.
> 
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> ---
> V3->V4 changes:
> * Modify the indentation format.

Did you test your patch before sending this time?

Best regards,
Krzysztof

Re: [PATCH V4] dt-bindings: serial: Add a new compatible string for UMS9632

[wenhua lin]

On Wed, Jan 22, 2025 at 3:53 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 22/01/2025 08:23, Wenhua Lin wrote:
> > The UART IP version of the ums9632 SoC project has been upgraded.
> > UART controller registers have added valid bits to support new features.
> > In order to distinguish different UART IP versions, we use sc9632-uart
> > to represent upgraded IP and sc9836-uart to represent old IP.
> >
> > Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> > ---
> > V3->V4 changes:
> > * Modify the indentation format.
>
> Did you test your patch before sending this time?
>
> Best regards,
> Krzysztof

hi Krzysztof:
   PATCH V4 dt_binding_check test result:

  wenhua.lin@f7fdd53ce35c:~/code/linux_update/linux$ make
DT_CHECKER_FLAGS=-m dt_binding_check W=1
O=/home/wenhua.lin/p/sprdikt/out/dt-out
DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/sprd-uart.yaml
  make[1]: Entering directory '/home/wenhua.lin/p/sprdikt/out/dt-out'
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  CHKDT   /home2/wenhua.lin/code/linux_update/linux/Documentation/devicetree/bindings
  LINT    /home2/wenhua.lin/code/linux_update/linux/Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/serial/sprd-uart.example.dts
  DTC [C] Documentation/devicetree/bindings/serial/sprd-uart.example.dtb
  make[1]: Leaving directory '/home/wenhua.lin/p/sprdikt/out/dt-out'

Thanks

Re: [PATCH V4] dt-bindings: serial: Add a new compatible string for UMS9632

[Krzysztof Kozlowski]

On 22/01/2025 08:23, Wenhua Lin wrote:
> The UART IP version of the ums9632 SoC project has been upgraded.
> UART controller registers have added valid bits to support new features.
> In order to distinguish different UART IP versions, we use sc9632-uart
> to represent upgraded IP and sc9836-uart to represent old IP.
> 
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> ---
> V3->V4 changes:


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof