The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: "Kristian Høgsberg" <krh@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2 v3] Use structs instead of hardcoded offsets in x86 boot decompressor.
Date: Thu, 29 May 2008 11:48:12 -0700	[thread overview]
Message-ID: <483EFA6C.6030804@zytor.com> (raw)
In-Reply-To: <1212082032-6167-1-git-send-email-krh@redhat.com>

Kristian Høgsberg wrote:
> 
> Updated this one to be less intrusive; we just re-#define RM_SCREEN_INFO to
> access the boot_params struct instead of using the hard-coded offset.
> 

Any reason to leave it in as a macro at all, instead of just 
s/RM_SCREEN_INFO/real_mode->screen_info/g?

We have already gotten rid of most of these macros in the primary kernel.

	-hpa

P.S. Sorry for not giving you feedback sooner.

  parent reply	other threads:[~2008-05-29 18:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-29 17:27 [PATCH 1/2 v3] Use structs instead of hardcoded offsets in x86 boot decompressor Kristian Høgsberg
2008-05-29 17:27 ` [PATCH 2/2] Honor 'quiet' command line option in real mode " Kristian Høgsberg
2008-05-29 18:43   ` H. Peter Anvin
2008-05-29 19:55     ` Kristian Høgsberg
2008-05-29 20:30       ` H. Peter Anvin
2008-05-29 22:25         ` Kristian Høgsberg
2008-05-29 18:48 ` H. Peter Anvin [this message]
2008-05-29 19:58   ` [PATCH 1/2 v3] Use structs instead of hardcoded offsets in x86 " Kristian Høgsberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483EFA6C.6030804@zytor.com \
    --to=hpa@zytor.com \
    --cc=krh@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox