From: "H. Peter Anvin" <hpa@zytor.com>
To: "Kristian Høgsberg" <krh@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Honor 'quiet' command line option in real mode boot decompressor.
Date: Thu, 29 May 2008 13:30:46 -0700 [thread overview]
Message-ID: <483F1276.30902@zytor.com> (raw)
In-Reply-To: <1212090939.6189.9.camel@gaara.bos.redhat.com>
Kristian Høgsberg wrote:
>> You know... we already have a command-line parser in the real-mode part
>> of the boot code, and it already extracts the "quiet" option: we should
>> be able to do this by passing a bit in "loadflags" (bit 5 suggested.)
>
> Hmm, as far as I understand the boot code, the decompressor consists of
> just head_32/64.S and misc.c plus the #included inflate.c and the
> compressed image in piggy.o. In this environment there is no command
> line parser, it's only available once the image has been decompressed.
> Or are you suggesting parsing the "quiet" option in the bootloader and
> then setting the loadflags bit from there? That's certainly doable, and
> I can update grub accordingly, but just parsing the command line seems
> like a simple, more local fix. I don't have a strong preference,
> though.
I think you're missing something: the decompressor is the *second stage*
of the boot code; the first stage is the real-mode code (arch/x86/boot).
I'm suggesting passing the flag from the real-mode code to the
decompressor, not from the boot loader (in the common case.)
-hpa
next prev parent reply other threads:[~2008-05-29 20:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 17:27 [PATCH 1/2 v3] Use structs instead of hardcoded offsets in x86 boot decompressor Kristian Høgsberg
2008-05-29 17:27 ` [PATCH 2/2] Honor 'quiet' command line option in real mode " Kristian Høgsberg
2008-05-29 18:43 ` H. Peter Anvin
2008-05-29 19:55 ` Kristian Høgsberg
2008-05-29 20:30 ` H. Peter Anvin [this message]
2008-05-29 22:25 ` Kristian Høgsberg
2008-05-29 18:48 ` [PATCH 1/2 v3] Use structs instead of hardcoded offsets in x86 " H. Peter Anvin
2008-05-29 19:58 ` Kristian Høgsberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483F1276.30902@zytor.com \
--to=hpa@zytor.com \
--cc=krh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox