[PATCH] x86: fix pointer type warning in arch/x86/mm/init_64.c:early_memtest

[PATCH] x86: fix pointer type warning in arch/x86/mm/init_64.c:early_memtest

[Kevin Winchester]

Changed the call to find_e820_area_size to pass u64 instead of unsigned long.

Signed-off-by: Kevin Winchester <kjwinchester@gmail.com>
---
 arch/x86/mm/init_64.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 83ab7f9..94f73c2 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -515,7 +515,7 @@ early_param("memtest", parse_memtest);
 
 static void __init early_memtest(unsigned long start, unsigned long end)
 {
-	unsigned long t_start, t_size;
+	u64 t_start, t_size;
 	unsigned pattern;
 
 	if (!memtest_pattern)
@@ -534,7 +534,7 @@ static void __init early_memtest(unsigned long start, unsigned long end)
 			if (t_start + t_size > end)
 				t_size = end - t_start;
 
-			printk(KERN_CONT "\n  %016lx - %016lx pattern %d",
+			printk(KERN_CONT "\n  %016llx - %016llx pattern %d",
 				t_start, t_start + t_size, pattern);
 
 			memtest(t_start, t_size, pattern);
-- 
1.5.5.40.g4cdda

Re: [PATCH] x86: fix pointer type warning in arch/x86/mm/init_64.c:early_memtest

[Kevin Winchester]

Kevin Winchester wrote:
> Changed the call to find_e820_area_size to pass u64 instead of unsigned long.
> 
> Signed-off-by: Kevin Winchester <kjwinchester@gmail.com>
> ---
>  arch/x86/mm/init_64.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> index 83ab7f9..94f73c2 100644
> --- a/arch/x86/mm/init_64.c
> +++ b/arch/x86/mm/init_64.c
> @@ -515,7 +515,7 @@ early_param("memtest", parse_memtest);
>  
>  static void __init early_memtest(unsigned long start, unsigned long end)
>  {
> -	unsigned long t_start, t_size;
> +	u64 t_start, t_size;
>  	unsigned pattern;
>  
>  	if (!memtest_pattern)
> @@ -534,7 +534,7 @@ static void __init early_memtest(unsigned long start, unsigned long end)
>  			if (t_start + t_size > end)
>  				t_size = end - t_start;
>  
> -			printk(KERN_CONT "\n  %016lx - %016lx pattern %d",
> +			printk(KERN_CONT "\n  %016llx - %016llx pattern %d",
>  				t_start, t_start + t_size, pattern);
>  
>  			memtest(t_start, t_size, pattern);


I was so excited about finally figuring out how to create and send a 
patch with git, that I forgot to mention that this was a warning seen in 
linux-next, next-20080529.

It was more an experiment in how to send git patches than to "get my 
name in the kernel history", with which most experienced developers seem 
to think us newbies are only concerned.  I keep hearing that testing 
trees and fixing warnings and small bugs is the preferred way to make it 
into development - so I'm giving it a try.

Let me know if there was anything wrong with this submission, or if it 
is too trivial to bother with.

-- 
Kevin Winchester

Re: [PATCH] x86: fix pointer type warning in arch/x86/mm/init_64.c:early_memtest

[Kevin Winchester]

Kevin Winchester wrote:
> Changed the call to find_e820_area_size to pass u64 instead of unsigned long.
> 
> Signed-off-by: Kevin Winchester <kjwinchester@gmail.com>
> ---
>  arch/x86/mm/init_64.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> index 83ab7f9..94f73c2 100644
> --- a/arch/x86/mm/init_64.c
> +++ b/arch/x86/mm/init_64.c
> @@ -515,7 +515,7 @@ early_param("memtest", parse_memtest);
>  
>  static void __init early_memtest(unsigned long start, unsigned long end)
>  {
> -	unsigned long t_start, t_size;
> +	u64 t_start, t_size;
>  	unsigned pattern;
>  
>  	if (!memtest_pattern)
> @@ -534,7 +534,7 @@ static void __init early_memtest(unsigned long start, unsigned long end)
>  			if (t_start + t_size > end)
>  				t_size = end - t_start;
>  
> -			printk(KERN_CONT "\n  %016lx - %016lx pattern %d",
> +			printk(KERN_CONT "\n  %016llx - %016llx pattern %d",
>  				t_start, t_start + t_size, pattern);
>  
>  			memtest(t_start, t_size, pattern);

I still see this warning on next-20080530 - so I expanded the CC list a 
little.  Did I do this patch right?

-- 
Kevin Winchester

Re: [PATCH] x86: fix pointer type warning in arch/x86/mm/init_64.c:early_memtest

[Yinghai Lu]

On Fri, May 30, 2008 at 5:34 PM, Kevin Winchester
<kjwinchester@gmail.com> wrote:
> Kevin Winchester wrote:
>>
>> Changed the call to find_e820_area_size to pass u64 instead of unsigned
>> long.
>>
>> Signed-off-by: Kevin Winchester <kjwinchester@gmail.com>
>> ---
>>  arch/x86/mm/init_64.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>> index 83ab7f9..94f73c2 100644
>> --- a/arch/x86/mm/init_64.c
>> +++ b/arch/x86/mm/init_64.c
>> @@ -515,7 +515,7 @@ early_param("memtest", parse_memtest);
>>   static void __init early_memtest(unsigned long start, unsigned long end)
>>  {
>> -       unsigned long t_start, t_size;
>> +       u64 t_start, t_size;
>>        unsigned pattern;
>>          if (!memtest_pattern)
>> @@ -534,7 +534,7 @@ static void __init early_memtest(unsigned long start,
>> unsigned long end)
>>                        if (t_start + t_size > end)
>>                                t_size = end - t_start;
>>  -                       printk(KERN_CONT "\n  %016lx - %016lx pattern
>> %d",
>> +                       printk(KERN_CONT "\n  %016llx - %016llx pattern
>> %d",
>>                                t_start, t_start + t_size, pattern);
>>                          memtest(t_start, t_size, pattern);
>
> I still see this warning on next-20080530 - so I expanded the CC list a
> little.  Did I do this patch right?

i had one in local too.

Acked-by: Yinghai Lu <yhlu.kernel@gmail.com>