* [PATCH 1/2] kobjects: Transmit return value of call_usermodehelper() to caller
@ 2008-06-24 8:59 Wang Chen
0 siblings, 0 replies; only message in thread
From: Wang Chen @ 2008-06-24 8:59 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Kay Sievers, linux-kernel
kobject_uevent_env() drops the return value of call_usermodehelper().
It will make upper caller, such as dm_send_uevents(), to lose error
information.
BTW, Previously kobject_uevent_env() transmitted return of
call_usermodehelper() to callers, but
commit 5f123fbd80f4f788554636f02bf73e40f914e0d6
"[PATCH] merge kobject_uevent and kobject_hotplug" removed it.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
---
diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 2fa545a..9f8d599 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -245,7 +245,8 @@ int kobject_uevent_env(struct kobject *kobj, enum kobject_action action,
if (retval)
goto exit;
- call_usermodehelper(argv[0], argv, env->envp, UMH_WAIT_EXEC);
+ retval = call_usermodehelper(argv[0], argv,
+ env->envp, UMH_WAIT_EXEC);
}
exit:
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-06-24 9:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-24 8:59 [PATCH 1/2] kobjects: Transmit return value of call_usermodehelper() to caller Wang Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox