The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH]: iommu fix potential overflow in alloc_iommu()
Date: Mon, 21 Jul 2008 11:21:39 -0400	[thread overview]
Message-ID: <4884A983.7010709@redhat.com> (raw)
In-Reply-To: <20080722001317N.fujita.tomonori@lab.ntt.co.jp>



FUJITA Tomonori wrote:
> On Mon, 21 Jul 2008 10:15:22 -0400
> Prarit Bhargava <prarit@redhat.com> wrote:
>
>   
>> (This didn't appear on LKML or any of the mirrors ... trying again)
>>
>> It is possible that alloc_iommu()'s boundary_size overflows as
>> dma_get_seg_boundary can return 0xffffffff.  In that case, further usage of
>> boundary_size triggers a BUG_ON() in the iommu code.
>>     
>
> Did you actually hit this? pci-gart_64.c is used only by X86_64.
>   

I hit this by declaring a device struct and not declaring a value for 
dev->dma_parms->segment_boundary_mask.

I was attempting to alloc out of the IOMMU and the code then dies on the 
bugcheck in iommu_is_span_boundary() because boundary_size = 0.

P.

  reply	other threads:[~2008-07-21 15:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-21 14:15 [PATCH]: iommu fix potential overflow in alloc_iommu() Prarit Bhargava
2008-07-21 14:15 ` [PATCH]: PCI: GART iommu alignment fixes Prarit Bhargava
2008-07-21 15:16   ` FUJITA Tomonori
2008-07-21 15:16 ` [PATCH]: iommu fix potential overflow in alloc_iommu() FUJITA Tomonori
2008-07-21 15:21   ` Prarit Bhargava [this message]
2008-07-21 15:46     ` FUJITA Tomonori
2008-07-21 15:47       ` Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4884A983.7010709@redhat.com \
    --to=prarit@redhat.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox