Re: [PATCH RESEND] sound: make OSS sound core optional

[Tejun Heo <tj@kernel.org>]

Hello,

Takashi Iwai wrote:
>> +config SOUND_OSS_CORE
>> +	bool
>> +	default n
>> +
>>  source "sound/oss/dmasound/Kconfig"
> 
> This seems missing from the scope.
> But, I think this should be rather in the block "if SOUND_PRIME" below.

SOUND_OSS_CORE should be turned on if ALSA OSS emul is turned on or
arch-um hostsound is turned on, both of which can be enabled regardless
of SOUND_PRIME, no?

>> --- work.orig/sound/sound_core.c
>> +++ work/sound/sound_core.c
> (snip)
>> +MODULE_ALIAS_CHARDEV_MAJOR(SOUND_MAJOR);
> 
> This alias should be in #ifdef CONFIG_SOUND_OSS_CORE.
> The module doesn't provide that major without CONFIG_SOUND_OSS_CORE.

Ah.. right.  Moving.

Thanks.

-- 
tejun