The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Tejun Heo <tj@kernel.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	alsa-devel@alsa-project.org, perex@perex.cz
Subject: Re: [PATCH RESEND] sound: make OSS sound core optional
Date: Wed, 27 Aug 2008 11:45:48 +0200	[thread overview]
Message-ID: <s5hvdxmkcz7.wl%tiwai@suse.de> (raw)
In-Reply-To: <48B52068.2090502@kernel.org>

At Wed, 27 Aug 2008 11:37:44 +0200,
Tejun Heo wrote:
> 
> Hello,
> 
> Takashi Iwai wrote:
> >> +config SOUND_OSS_CORE
> >> +	bool
> >> +	default n
> >> +
> >>  source "sound/oss/dmasound/Kconfig"
> > 
> > This seems missing from the scope.
> > But, I think this should be rather in the block "if SOUND_PRIME" below.
> 
> SOUND_OSS_CORE should be turned on if ALSA OSS emul is turned on or
> arch-um hostsound is turned on, both of which can be enabled regardless
> of SOUND_PRIME, no?

Yes, sorry, I didn't cite clearly.  I meant only the last line.
sound/oss/dmasound/Kconfig is included and evaluated outside the block
"if SOUND_PRIME".  Thus, CONFIG_SOUND_OSS_CORE won't be enabled for
drivers in sound/oss/dmasound.

My suggestion is to move that line source sound/oss/dmasound/Kconfig
into the "if SOUND_PRIME" block first, then apply your patch.

Anyway, there are some other minor issues in sound/Kconfig, for
example, why "if !M68K" is there.  We can clean up a bit more.


thanks,

Takashi

  reply	other threads:[~2008-08-27  9:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27  8:19 [PATCH RESEND] sound: make OSS sound core optional Tejun Heo
2008-08-27  9:09 ` Takashi Iwai
2008-08-27  9:37   ` Tejun Heo
2008-08-27  9:45     ` Takashi Iwai [this message]
2008-08-27  9:57       ` Tejun Heo
2008-08-27 10:04         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hvdxmkcz7.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox