[PATCH] x86: pgd_{c,d}tor() cleanup

[PATCH] x86: pgd_{c,d}tor() cleanup

[Jan Beulich]

Giving pgd_ctor() a properly typed parameter allows eliminating a local
variable. Adjust pgd_dtor() to match.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Acked-by: Jeremy Fitzhardinge <jeremy@goop.org>

---
 arch/x86/mm/pgtable.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- linux-2.6.27-rc5/arch/x86/mm/pgtable.c	2008-08-21 14:37:29.000000000 +0200
+++ 2.6.27-rc5-x86-pgd-alloc-cleanup/arch/x86/mm/pgtable.c	2008-08-19 11:57:23.000000000 +0200
@@ -63,10 +63,8 @@ static inline void pgd_list_del(pgd_t *p
 #define UNSHARED_PTRS_PER_PGD				\
 	(SHARED_KERNEL_PMD ? KERNEL_PGD_BOUNDARY : PTRS_PER_PGD)
 
-static void pgd_ctor(void *p)
+static void pgd_ctor(pgd_t *pgd)
 {
-	pgd_t *pgd = p;
-
 	/* If the pgd points to a shared pagetable level (either the
 	   ptes in non-PAE, or shared PMD in PAE), then just copy the
 	   references from swapper_pg_dir. */
@@ -87,7 +85,7 @@ static void pgd_ctor(void *p)
 		pgd_list_add(pgd);
 }
 
-static void pgd_dtor(void *pgd)
+static void pgd_dtor(pgd_t *pgd)
 {
 	unsigned long flags; /* can be called from interrupt context */
 

Re: [PATCH] x86: pgd_{c,d}tor() cleanup

[Ingo Molnar]

* Jan Beulich <jbeulich@novell.com> wrote:

> Giving pgd_ctor() a properly typed parameter allows eliminating a local
> variable. Adjust pgd_dtor() to match.
> 
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> Acked-by: Jeremy Fitzhardinge <jeremy@goop.org>

applied to tip/x86/cleanups, thanks Jan.

	Ingo