Re: [PATCH v6 3/4] platform: int3472: discrete: con_id vana for Sony IMX471 as power enable

[Hans de Goede <hansg@kernel.org>]

Hi All,

On 30-Jun-26 09:32, Tarang Raval wrote:
> Hi Kate,
> 
>> Update the con_id for the Sony IMX471 sensor to "vana" to serve as the
>> power enable. Additionally, the HID values SONY471A and TBE20A0, both
>> associated with the IMX471 image sensor, have been identified on Lenovo
>> laptops.
>>
>> Signed-off-by: Kate Hsuan <hpa@redhat.com>
> 
> Thanks, looks good.
> 
> Reviewed-by: Tarang Raval <tarang.raval@siliconsignals.io>

Hmm, the imx471 driver is still pending upstream:

https://lore.kernel.org/linux-media/20260629074026.35490-5-hpa@redhat.com/

As part of this series.

Please just use the standardized "avdd" in that driver instead
of "vana" (which also seems to refer to the analog supply vdd,
which is what avdd stands for).

Then this whole patch is unnecessary and can be dropped from
this series.

Regards,

Hans




>> ---
>>  drivers/platform/x86/intel/int3472/discrete.c | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>
>> diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
>> index 115bb37577a1..adff564bf3fd 100644
>> --- a/drivers/platform/x86/intel/int3472/discrete.c
>> +++ b/drivers/platform/x86/intel/int3472/discrete.c
>> @@ -164,6 +164,24 @@ static const struct int3472_gpio_map int3472_gpio_map[] = {
>>                 .con_id = "dvdd",
>>                 .enable_time_us = 45 * USEC_PER_MSEC,
>>         },
>> +       {       /* imx471 expects "vana" as con_id for power enable */
>> +               .hid = "SONY471A",
>> +               .type_from = INT3472_GPIO_TYPE_POWER_ENABLE,
>> +               .type_to = INT3472_GPIO_TYPE_POWER_ENABLE,
>> +               .con_id = "vana",
>> +               .enable_time_us = GPIO_REGULATOR_ENABLE_TIME,
>> +       },
>> +       {
>> +               /*
>> +                * imx471 (on Lenovo ThinkPads X1 G14) expects "vana" as con_id
>> +                * for power enable
>> +                */
>> +               .hid = "TBE20A0",
>> +               .type_from = INT3472_GPIO_TYPE_POWER_ENABLE,
>> +               .type_to = INT3472_GPIO_TYPE_POWER_ENABLE,
>> +               .con_id = "vana",
>> +               .enable_time_us = GPIO_REGULATOR_ENABLE_TIME,
>> +       },
>>  };
>>
>>  static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3472, u8 *type,
>> --
>> 2.54.0