The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCHSET] fix CGROUP VS RCU
@ 2008-11-21  8:49 Lai Jiangshan
  2008-11-21  9:06 ` Andrew Morton
  0 siblings, 1 reply; 4+ messages in thread
From: Lai Jiangshan @ 2008-11-21  8:49 UTC (permalink / raw)
  To: Andrew Morton, Paul Menage, Linux Containers,
	Linux Kernel Mailing List, KAMEZAWA Hiroyuki, Serge Hallyn


current some cgroup struct are protected by RCU.

struct protected by RCU:
	struct css_set, struct cgroup_subsys_state, struct cgroup

pointer protected by RCU:
	struct task_struct.cgroups, struct css_set.subsys[*],
	struct cgroup_subsys_state.cgroup
the last two pointers are readonly pointer!

these patches are fix these structs, and pointers. And a faker:
struct cgroup_subsys.root

Not cleanup all yet.

Thanx, Lai


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCHSET] fix CGROUP VS RCU
  2008-11-21  8:49 [PATCHSET] fix CGROUP VS RCU Lai Jiangshan
@ 2008-11-21  9:06 ` Andrew Morton
  2008-11-21  9:10   ` Lai Jiangshan
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2008-11-21  9:06 UTC (permalink / raw)
  To: Lai Jiangshan
  Cc: Paul Menage, Linux Containers, Linux Kernel Mailing List,
	KAMEZAWA Hiroyuki, Serge Hallyn

On Fri, 21 Nov 2008 16:49:13 +0800 Lai Jiangshan <laijs@cn.fujitsu.com> wrote:

> 
> current some cgroup struct are protected by RCU.
> 
> struct protected by RCU:
> 	struct css_set, struct cgroup_subsys_state, struct cgroup
> 
> pointer protected by RCU:
> 	struct task_struct.cgroups, struct css_set.subsys[*],
> 	struct cgroup_subsys_state.cgroup
> the last two pointers are readonly pointer!
> 
> these patches are fix these structs, and pointers. And a faker:
> struct cgroup_subsys.root
> 
> Not cleanup all yet.
> 

These patches aren't sequence numbered.  In what order should they be
applied?


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCHSET] fix CGROUP VS RCU
  2008-11-21  9:06 ` Andrew Morton
@ 2008-11-21  9:10   ` Lai Jiangshan
  2008-11-21  9:14     ` Lai Jiangshan
  0 siblings, 1 reply; 4+ messages in thread
From: Lai Jiangshan @ 2008-11-21  9:10 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Paul Menage, Linux Containers, Linux Kernel Mailing List,
	KAMEZAWA Hiroyuki, Serge Hallyn

Andrew Morton wrote:
> On Fri, 21 Nov 2008 16:49:13 +0800 Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> 
>> current some cgroup struct are protected by RCU.
>>
>> struct protected by RCU:
>> 	struct css_set, struct cgroup_subsys_state, struct cgroup
>>
>> pointer protected by RCU:
>> 	struct task_struct.cgroups, struct css_set.subsys[*],
>> 	struct cgroup_subsys_state.cgroup
>> the last two pointers are readonly pointer!
>>
>> these patches are fix these structs, and pointers. And a faker:
>> struct cgroup_subsys.root
>>
>> Not cleanup all yet.
>>
> 
> These patches aren't sequence numbered.  In what order should they be
> applied?
> 
> 
> 
> 

No order number, they are dependent(except 2 patches which have order number).

Lai.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCHSET] fix CGROUP VS RCU
  2008-11-21  9:10   ` Lai Jiangshan
@ 2008-11-21  9:14     ` Lai Jiangshan
  0 siblings, 0 replies; 4+ messages in thread
From: Lai Jiangshan @ 2008-11-21  9:14 UTC (permalink / raw)
  To: Lai Jiangshan
  Cc: Andrew Morton, Paul Menage, Linux Containers,
	Linux Kernel Mailing List, KAMEZAWA Hiroyuki, Serge Hallyn

Lai Jiangshan wrote:
> Andrew Morton wrote:
>> On Fri, 21 Nov 2008 16:49:13 +0800 Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
>>
>>> current some cgroup struct are protected by RCU.
>>>
>>> struct protected by RCU:
>>> 	struct css_set, struct cgroup_subsys_state, struct cgroup
>>>
>>> pointer protected by RCU:
>>> 	struct task_struct.cgroups, struct css_set.subsys[*],
>>> 	struct cgroup_subsys_state.cgroup
>>> the last two pointers are readonly pointer!
>>>
>>> these patches are fix these structs, and pointers. And a faker:
>>> struct cgroup_subsys.root
>>>
>>> Not cleanup all yet.
>>>
>> These patches aren't sequence numbered.  In what order should they be
>> applied?
>>
>>
>>
>>
> 
> No order number, they are dependent(except 2 patches which have order number).

                            dependent --> independent

> 
> Lai.
> 
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-11-21  9:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-21  8:49 [PATCHSET] fix CGROUP VS RCU Lai Jiangshan
2008-11-21  9:06 ` Andrew Morton
2008-11-21  9:10   ` Lai Jiangshan
2008-11-21  9:14     ` Lai Jiangshan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox