Re: mmotm 2008-12-16-00-43 uploaded (fs)

Re: mmotm 2008-12-16-00-43 uploaded (fs)

[Randy Dunlap]

akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2008-12-16-00-43 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> It contains the following patches against 2.6.28-rc8:
> 
> fs-symlink-write_begin-allocation-context-fix.patch

Nick,

fuse and reiser4 still use __grab_cache_page() although your patch
removed it:

build-r7257.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/reiser4/plugin/file/file_conversi
on.c:689: error: implicit declaration of function '__grab_cache_page'
build-r7257.out:make[3]: *** [fs/reiser4/plugin/file/file_conversion.o] Error 1

build-r7248.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/fuse/file.c:792: error: implicit declaration of function '__grab_cache_page'
build-r7248.out:make[3]: *** [fs/fuse/file.o] Error 1

~Randy

Re: mmotm 2008-12-16-00-43 uploaded (sparse irq)

[Randy Dunlap]

akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2008-12-16-00-43 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> It contains the following patches against 2.6.28-rc8:
> 
> irq-enclose-irq_desc_lock_class-in-config_sparse_irq.patch

whose patch is that?

If CONFIG_SPARSE_IRQ is not enabled, then builds fail with:

build-r7248.out:/local/linsrc/tmp/mmotm-2008-1216-0043/kernel/irq/handle.c:434: error: 'irq_desc_lock_class' undeclared (first use in this function)
build-r7248.out:make[3]: *** [kernel/irq/handle.o] Error 1


~Randy

Re: mmotm 2008-12-16-00-43 uploaded (fs)

[Randy Dunlap]

Randy Dunlap wrote:
> akpm@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2008-12-16-00-43 has been uploaded to
>>
>>    http://userweb.kernel.org/~akpm/mmotm/
>>
>> It contains the following patches against 2.6.28-rc8:
>>
>> fs-symlink-write_begin-allocation-context-fix.patch
> 
> Nick,
> 
> fuse and reiser4 still use __grab_cache_page() although your patch
> removed it:
> 
> build-r7257.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/reiser4/plugin/file/file_conversi
> on.c:689: error: implicit declaration of function '__grab_cache_page'
> build-r7257.out:make[3]: *** [fs/reiser4/plugin/file/file_conversion.o] Error 1
> 
> build-r7248.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/fuse/file.c:792: error: implicit declaration of function '__grab_cache_page'
> build-r7248.out:make[3]: *** [fs/fuse/file.o] Error 1


One more related error:

build-r7258.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/ubifs/file.c:251: error: 'flags' undeclared (first use in this function)
build-r7258.out:make[3]: *** [fs/ubifs/file.o] Error 1

Re: mmotm 2008-12-16-00-43 uploaded (fs)

[Andrew Morton]

On Tue, 16 Dec 2008 10:00:56 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote:

> Randy Dunlap wrote:
> > akpm@linux-foundation.org wrote:
> >> The mm-of-the-moment snapshot 2008-12-16-00-43 has been uploaded to
> >>
> >>    http://userweb.kernel.org/~akpm/mmotm/
> >>
> >> It contains the following patches against 2.6.28-rc8:
> >>
> >> fs-symlink-write_begin-allocation-context-fix.patch
> > 
> > Nick,
> > 
> > fuse and reiser4 still use __grab_cache_page() although your patch
> > removed it:
> > 
> > build-r7257.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/reiser4/plugin/file/file_conversi
> > on.c:689: error: implicit declaration of function '__grab_cache_page'
> > build-r7257.out:make[3]: *** [fs/reiser4/plugin/file/file_conversion.o] Error 1
> > 
> > build-r7248.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/fuse/file.c:792: error: implicit declaration of function '__grab_cache_page'
> > build-r7248.out:make[3]: *** [fs/fuse/file.o] Error 1
> 
> 
> One more related error:
> 
> build-r7258.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/ubifs/file.c:251: error: 'flags' undeclared (first use in this function)
> build-r7258.out:make[3]: *** [fs/ubifs/file.o] Error 1

thanks, I dropped it.

Re: mmotm 2008-12-16-00-43 uploaded (fs)

[KOSAKI Motohiro]

> On Tue, 16 Dec 2008 10:00:56 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> 
> > Randy Dunlap wrote:
> > > akpm@linux-foundation.org wrote:
> > >> The mm-of-the-moment snapshot 2008-12-16-00-43 has been uploaded to
> > >>
> > >>    http://userweb.kernel.org/~akpm/mmotm/
> > >>
> > >> It contains the following patches against 2.6.28-rc8:
> > >>
> > >> fs-symlink-write_begin-allocation-context-fix.patch
> > > 
> > > Nick,
> > > 
> > > fuse and reiser4 still use __grab_cache_page() although your patch
> > > removed it:
> > > 
> > > build-r7257.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/reiser4/plugin/file/file_conversi
> > > on.c:689: error: implicit declaration of function '__grab_cache_page'
> > > build-r7257.out:make[3]: *** [fs/reiser4/plugin/file/file_conversion.o] Error 1
> > > 
> > > build-r7248.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/fuse/file.c:792: error: implicit declaration of function '__grab_cache_page'
> > > build-r7248.out:make[3]: *** [fs/fuse/file.o] Error 1
> > 
> > 
> > One more related error:
> > 
> > build-r7258.out:/local/linsrc/tmp/mmotm-2008-1216-0043/fs/ubifs/file.c:251: error: 'flags' undeclared (first use in this function)
> > build-r7258.out:make[3]: *** [fs/ubifs/file.o] Error 1
> 
> thanks, I dropped it.

I'm sad ;)

I have fixing patch. this patch series have

1) reiser4 fix
2) ubifs fix
3) fuse fix



Tested on mmotm1217 + fs-symlink-write_begin-allocation-context-fix.patch

==
Subject: [PATCH 1/3] fix reiser4 build error of fs-symlink-write_begin-allocation-context-fix.patch

build fix.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
 fs/reiser4/plugin/file/file_conversion.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: b/fs/reiser4/plugin/file/file_conversion.c
===================================================================
--- a/fs/reiser4/plugin/file/file_conversion.c
+++ b/fs/reiser4/plugin/file/file_conversion.c
@@ -686,7 +686,8 @@ int reiser4_write_begin_careful(struct f
 	start = pos & (PAGE_CACHE_SIZE - 1);
 	end = start + len;
 
-	page = __grab_cache_page(mapping, index);
+	page = grab_cache_page_write_begin(mapping, index,
+					   flags & AOP_FLAG_NOFS);
 	*pagep = page;
 	if (!page)
 		return -ENOMEM;

Re: mmotm 2008-12-16-00-43 uploaded (fs)

[KOSAKI Motohiro]

> I have fixing patch. this patch series have
> 
> 1) reiser4 fix
> 2) ubifs fix
> 3) fuse fix
> 



Tested on mmotm1217 + fs-symlink-write_begin-allocation-context-fix.patch

==
Subject: [PATCH 2/3] fix ubifs build error of fs-symlink-write_begin-allocation-context-fix.patch

build fix.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
 fs/ubifs/file.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: b/fs/ubifs/file.c
===================================================================
--- a/fs/ubifs/file.c
+++ b/fs/ubifs/file.c
@@ -219,7 +219,8 @@ static void release_existing_page_budget
 }
 
 static int write_begin_slow(struct address_space *mapping,
-			    loff_t pos, unsigned len, struct page **pagep)
+			    loff_t pos, unsigned len, struct page **pagep,
+			    unsigned flags)
 {
 	struct inode *inode = mapping->host;
 	struct ubifs_info *c = inode->i_sb->s_fs_info;
@@ -485,7 +486,7 @@ static int ubifs_write_begin(struct file
 		unlock_page(page);
 		page_cache_release(page);
 
-		return write_begin_slow(mapping, pos, len, pagep);
+		return write_begin_slow(mapping, pos, len, pagep, flags);
 	}
 
 	/*

Re: mmotm 2008-12-16-00-43 uploaded (fs)

[KOSAKI Motohiro]

> I have fixing patch. this patch series have
> 
> 1) reiser4 fix
> 2) ubifs fix
> 3) fuse fix


Tested on mmotm1217 + fs-symlink-write_begin-allocation-context-fix.patch

==
Subject: [PATCH 3/3] fix fuse build error of fs-symlink-write_begin-allocation-context-fix.patch

build fix.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
 fs/fuse/file.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/fs/fuse/file.c
===================================================================
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -789,7 +789,7 @@ static ssize_t fuse_fill_write_pages(str
 			break;
 
 		err = -ENOMEM;
-		page = __grab_cache_page(mapping, index);
+		page = grab_cache_page_write_begin(mapping, index, 0);
 		if (!page)
 			break;
 

Re: mmotm 2008-12-16-00-43 uploaded (fs)

[Nick Piggin]

On Thu, Dec 18, 2008 at 08:47:57PM +0900, KOSAKI Motohiro wrote:
> > 
> > thanks, I dropped it.
> 
> I'm sad ;)
> 
> I have fixing patch. this patch series have
> 
> 1) reiser4 fix
> 2) ubifs fix
> 3) fuse fix

Thank you very much for doing these. They look good to me.