From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Manish Katiyar <mkatiyar@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c
Date: Mon, 16 Feb 2009 15:00:31 +0100 [thread overview]
Message-ID: <4999717F.7090205@s5r6.in-berlin.de> (raw)
In-Reply-To: <20090216132822.GC17996@elte.hu>
Ingo Molnar wrote:
> * Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
>> Furthermore, the changelog is bad (non-exiting in fact).
>>
>> The fact that the issues where discovered using checkpatch is absolutely
>> uninteresting. The changelog should describe /what/ is fixed, [...]
>
> The commit log definitely needs enhancements but it's not uninteresting
> at all what tools were used to arrive to a change. [...] if a
> good and acceptable commit results out of a tool's usage then that tool
> needs to be advertised some more.)
Fine, then the author could mention it below the --- delimitor in the
patch posting. The changelog however, as annotation of the source
history, is not a billboard. We also don't describe for example that a
nice cup of hot Earl Grey or whatever was vital to the creation of a patch.
--
Stefan Richter
-=====-==--= --=- =----
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-02-16 14:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 18:34 [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Manish Katiyar
2009-02-15 18:47 ` Sam Ravnborg
2009-02-15 18:47 ` Manish Katiyar
2009-02-16 13:07 ` Stefan Richter
2009-02-16 13:28 ` Ingo Molnar
2009-02-16 14:00 ` Stefan Richter [this message]
2009-02-16 14:19 ` Ingo Molnar
2009-02-16 15:22 ` Stefan Richter
2009-02-16 15:41 ` Manish Katiyar
2009-02-16 15:50 ` Ingo Molnar
2009-02-16 16:13 ` Stefan Richter
2009-02-16 17:12 ` Ingo Molnar
2009-02-16 18:04 ` Stefan Richter
2009-02-16 16:13 ` Al Viro
2009-02-16 17:11 ` Ingo Molnar
2009-02-16 14:28 ` Paolo Ciarrocchi
2009-02-16 16:17 ` Julia Lawall
2009-02-16 16:35 ` Stefan Richter
2009-02-16 17:21 ` Ingo Molnar
2009-02-16 17:15 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4999717F.7090205@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mkatiyar@gmail.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox