public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Julia Lawall <julia@diku.dk>
Cc: Ingo Molnar <mingo@elte.hu>, Sam Ravnborg <sam@ravnborg.org>,
	Manish Katiyar <mkatiyar@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c
Date: Mon, 16 Feb 2009 17:35:16 +0100	[thread overview]
Message-ID: <499995C4.3070504@s5r6.in-berlin.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0902161711580.9565@pc-004.diku.dk>

Julia Lawall wrote:
> Is everything below the --- preserved in what is available via git log?  

No, none of it (if the patch is mechanically applied with e.g. git-am).

Sometimes, useful information does indeed get lost because an author
didn't consider it "above ---"-worthy.

...
> I think the how information has some value, 
> both to make people aware of what tools are useful for what kinds of 
> tasks, and to help one understand what criteria were used in making the 
> patch.

That information is perfect for conservation mailing list archives.

The source repository metadata (commit logs) have other purposes:  Keep
book about what happened to the source code and why.

> This can sometimes be conveyed more precisely using code than 
> English text.

If the scope of a change is better captured that way, then OK.

> I agree that the how information is not always relevant for 
> the person who just wants to scan a changelog to see what is new in the 
> current Linux release.

The changelog is not only to learn what's new (i.e. a source of release
notes), it's also to learn what's old. :-)  I go through old changelogs
all the time because I deal with code with history older than my
involvement or too old for me to remember the circumstances.
-- 
Stefan Richter
-=====-==--= --=- =----
http://arcgraph.de/sr/

  reply	other threads:[~2009-02-16 16:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-15 18:34 [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c Manish Katiyar
2009-02-15 18:47 ` Sam Ravnborg
2009-02-15 18:47   ` Manish Katiyar
2009-02-16 13:07   ` Stefan Richter
2009-02-16 13:28     ` Ingo Molnar
2009-02-16 14:00       ` Stefan Richter
2009-02-16 14:19         ` Ingo Molnar
2009-02-16 15:22           ` Stefan Richter
2009-02-16 15:41             ` Manish Katiyar
2009-02-16 15:50             ` Ingo Molnar
2009-02-16 16:13               ` Stefan Richter
2009-02-16 17:12                 ` Ingo Molnar
2009-02-16 18:04                   ` Stefan Richter
2009-02-16 16:13               ` Al Viro
2009-02-16 17:11                 ` Ingo Molnar
2009-02-16 14:28       ` Paolo Ciarrocchi
2009-02-16 16:17       ` Julia Lawall
2009-02-16 16:35         ` Stefan Richter [this message]
2009-02-16 17:21           ` Ingo Molnar
2009-02-16 17:15         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499995C4.3070504@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mkatiyar@gmail.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox