* [PATCH] remove pointless strdup() on arguments passed to new_module()
@ 2009-03-12 12:28 Jan Beulich
2009-04-10 7:01 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2009-03-12 12:28 UTC (permalink / raw)
To: sam; +Cc: linux-kernel
new_module() itself already calls strdup() on its modname parameter.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
scripts/mod/modpost.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.29-rc7/scripts/mod/modpost.c 2008-12-25 00:26:37.000000000 +0100
+++ 2.6.29-rc7-module-modpost/scripts/mod/modpost.c 2009-01-20 09:47:23.000000000 +0100
@@ -1910,7 +1910,7 @@ static void read_dump(const char *fname,
if (!mod) {
if (is_vmlinux(modname))
have_vmlinux = 1;
- mod = new_module(NOFAIL(strdup(modname)));
+ mod = new_module(modname);
mod->skip = 1;
}
s = sym_add_exported(symname, mod, export_no(export));
@@ -1994,7 +1994,7 @@ static void read_markers(const char *fna
mod = find_module(modname);
if (!mod) {
- mod = new_module(NOFAIL(strdup(modname)));
+ mod = new_module(modname);
mod->skip = 1;
}
if (is_vmlinux(modname)) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-10 6:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-12 12:28 [PATCH] remove pointless strdup() on arguments passed to new_module() Jan Beulich
2009-04-10 7:01 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox