* [PATCH] staging: missing parentheses?
@ 2009-05-14 11:58 Roel Kluin
0 siblings, 0 replies; only message in thread
From: Roel Kluin @ 2009-05-14 11:58 UTC (permalink / raw)
To: Greg KH; +Cc: lkml, Andrew Morton
Add missing parentheses.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
The original code looks odd, but I am not sure whether my patch is correct.
So please review.
diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
index 43a9d56..a6fbf43 100644
--- a/drivers/staging/comedi/drivers/pcl818.c
+++ b/drivers/staging/comedi/drivers/pcl818.c
@@ -460,9 +460,9 @@ static int pcl818_ao_insn_write(struct comedi_device * dev, struct comedi_subdev
for (n = 0; n < insn->n; n++) {
devpriv->ao_readback[chan] = data[n];
outb((data[n] & 0x000f) << 4, dev->iobase +
- (chan) ? PCL718_DA2_LO : PCL818_DA_LO);
+ (chan ? PCL718_DA2_LO : PCL818_DA_LO));
outb((data[n] & 0x0ff0) >> 4, dev->iobase +
- (chan) ? PCL718_DA2_HI : PCL818_DA_HI);
+ (chan ? PCL718_DA2_HI : PCL818_DA_HI));
}
return n;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-05-14 11:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-14 11:58 [PATCH] staging: missing parentheses? Roel Kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox