From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org,
Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH 2/2] firewire: core: add sysfs attribute for easier udev rules
Date: Sat, 23 May 2009 00:03:29 +0200 [thread overview]
Message-ID: <4A172131.5010005@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.acafb37c21e20784@s5r6.in-berlin.de>
Stefan Richter wrote:
> + while (fw_csr_iterator_next(&ci, &key, &value)) {
> + if (key != (CSR_UNIT | CSR_DIRECTORY))
> + continue;
> + i += units_sprintf(&buf[i], ci.p + value - 1);
> + if (i >= PAGE_SIZE - (8 + 1 + 8 + 1))
> + break;
> + }
> + up_read(&fw_device_rwsem);
> +
> + sprintf(&buf[i ? i - 1 : 0], "\n");
Rather:
if (i)
buf[i - 1] = '\n';
> +
> + return i;
> +}
--
Stefan Richter
-=====-==--= -=-= =-===
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-05-22 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tkrat.d86e749d664670a9@s5r6.in-berlin.de>
[not found] ` <ac3eb2510905211001m77eda9e4gb73001d504fd5376@mail.gmail.com>
[not found] ` <4A159899.20506@s5r6.in-berlin.de>
[not found] ` <4A165CED.8030601@s5r6.in-berlin.de>
[not found] ` <ac3eb2510905220423h23e7aca1u3bc7c204db551eb0@mail.gmail.com>
2009-05-22 21:16 ` [PATCH 1/2] firewire: core: check for missing struct update at build time, not run time Stefan Richter
2009-05-22 21:17 ` [PATCH 2/2] firewire: core: add sysfs attribute for easier udev rules Stefan Richter
2009-05-22 22:03 ` Stefan Richter [this message]
2009-05-23 0:35 ` Kay Sievers
2009-05-24 12:09 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A172131.5010005@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox