The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] drm: Fixes error with gcc 3.3.5 in i915 driver.
@ 2009-06-23 12:45 Torsten Hilbrich
  0 siblings, 0 replies; only message in thread
From: Torsten Hilbrich @ 2009-06-23 12:45 UTC (permalink / raw)
  To: linux-kernel; +Cc: Dave Airlie, Zhenyu Wang

When compiling with gcc 3.3.5 I got the following error message in the
module i915.ko:

ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined!

This error did not occur when compiling the same code in gcc 4.3.2.

This patch replaces the 64 bit division by a call of div_u64 to avoid
triggering the problem on the older compiler.

The code to be fixed was introduced in
commit 2c07245fb8f7f0a282282e5a9747e46defdb2cc7
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 3e1c781..306d198 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1502,7 +1502,7 @@ igdng_compute_m_n(int bytes_per_pixel, int nlanes,

 	temp = (u64) DATA_N * pixel_clock;
 	temp = div_u64(temp, link_clock);
-	m_n->gmch_m = (temp * bytes_per_pixel) / nlanes;
+	m_n->gmch_m = div_u64(temp * byte_per_pixel, nlanes);
 	m_n->gmch_n = DATA_N;
 	fdi_reduce_ratio(&m_n->gmch_m, &m_n->gmch_n);

-- 
1.5.4.2


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-23 13:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-23 12:45 [PATCH] drm: Fixes error with gcc 3.3.5 in i915 driver Torsten Hilbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox