From: "Justin P. Mattock" <justinmattock@gmail.com>
To: James Morris <jmorris@namei.org>
Cc: linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov
Subject: Re: [PATCH] SElinux: Fix some typos.
Date: Thu, 02 Jul 2009 20:35:48 -0700 [thread overview]
Message-ID: <4A4D7C94.2020307@gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.00.0907030850500.10242@tundra.namei.org>
James Morris wrote:
> On Thu, 2 Jul 2009, Justin P. Mattock wrote:
>
>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>
>> Fix some typos in some comments.
>>
>
>
>> -/* The file system's label must be initialized prior to use. */
>> +/* The filesystems label must be initialized prior to use. */
>>
>
> Your adding grammertical error's.
>
>
well, after figuring out how to have git send -email functioning correctly,
I needed something to send. : ^ )
(but after doing a quick google filesystem did show up).
>> - * Note that the setting of hard limits (even to lower them) can be
>> + * Note: That the setting of hard limits (even to lower them) can be
>>
>
> Please get this patch reviewed by an English speaker.
>
>
That seems viable to me.
>> * Description:
>> * Call the NetLabel mechanism to get the security attributes of the given
>> - * packet and use those attributes to determine the correct context/SID to
>> - * assign to the packet. Returns zero on success, negative values on failure.
>> + * packet and use those attributes to determine the correct context/SID to be
>> + * assigned to the packet. Returns zero on success, negative values on failure.
>>
>
> Eschew the active voice?
>
>
> - James
>
wast ist das?
No I will not be afraid of submitting patches, and having them be rejected.
all part of the learning curve.
Justin P. Mattock
next prev parent reply other threads:[~2009-07-03 3:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 17:46 SELinux-Fix-some-typos Justin P. Mattock
2009-07-02 17:46 ` [PATCH] SElinux: Fix some typos Justin P. Mattock
2009-07-02 22:56 ` James Morris
2009-07-03 3:35 ` Justin P. Mattock [this message]
2009-07-03 5:51 ` James Morris
2009-07-03 6:23 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4D7C94.2020307@gmail.com \
--to=justinmattock@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox