From: "Justin P. Mattock" <justinmattock@gmail.com>
To: James Morris <jmorris@namei.org>
Cc: linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov
Subject: Re: [PATCH] SElinux: Fix some typos.
Date: Thu, 02 Jul 2009 23:23:28 -0700 [thread overview]
Message-ID: <4A4DA3E0.6050404@gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.00.0907031544160.12340@tundra.namei.org>
James Morris wrote:
> On Thu, 2 Jul 2009, Justin P. Mattock wrote:
>
>
>> No I will not be afraid of submitting patches, and having them be rejected.
>> all part of the learning curve.
>>
>
> I'd suggest generally not starting out with spelling, grammatical and
> formatting patches. It eats reviewer bandwidth, perturbs the codebase
> (causing people working on it to have to update their code) and does not
> give you as much opportunity to to learn about the code.
>
>
No my intentions were not to eat reviewer bandwidth, or get in the way.
just turned out as I was going through(for example) hooks.c I noticed a
portion of it
had proper grammar, and then a portion of it seemed as if the author was too
much in a hurry to worry about that.(so I figured hey why not, that's all).
> Try fixing smaller, known bugs or adding small useful changes.
>
> The TODO list for the SELinux kernel code is here:
> http://selinuxproject.org/page/Kernel_Development
>
>
Thanks for this, Ill have to give this a look and see.
> You can also email the maintainers and ask for suggestions on what to
> tackle.
>
>
> - James
>
alright James,
Thanks for taking the time
next time I decide to have a major case of
OCD, I'll remember that creating churn is not
a good idea.
Justin P. Mattock
prev parent reply other threads:[~2009-07-03 6:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 17:46 SELinux-Fix-some-typos Justin P. Mattock
2009-07-02 17:46 ` [PATCH] SElinux: Fix some typos Justin P. Mattock
2009-07-02 22:56 ` James Morris
2009-07-03 3:35 ` Justin P. Mattock
2009-07-03 5:51 ` James Morris
2009-07-03 6:23 ` Justin P. Mattock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4DA3E0.6050404@gmail.com \
--to=justinmattock@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox