[PATCH] thinkpad-acpi: should error return be nagative?

[PATCH] thinkpad-acpi: should error return be nagative?

[Roel Kluin]

The returned error should be negative

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
 drivers/platform/x86/thinkpad_acpi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Is this maybe required?

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index d93108d..03c0a56 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6313,7 +6313,7 @@ static int brightness_write(char *buf)
 	 * Doing it this way makes the syscall restartable in case of EINTR
 	 */
 	rc = brightness_set(level);
-	return (rc == -EINTR)? ERESTARTSYS : rc;
+	return (rc == -EINTR)? -ERESTARTSYS : rc;
 }
 
 static struct ibm_struct brightness_driver_data = {

Re: [PATCH] thinkpad-acpi: should error return be nagative?

[Henrique de Moraes Holschuh]

On Fri, 20 Nov 2009, Roel Kluin wrote:
> The returned error should be negative
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
>  drivers/platform/x86/thinkpad_acpi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Is this maybe required?

Yes, it is.  Thank you for noticing this.

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: stable@kernel.org

I will queue it, and send it in during the merge window, and also to -stable
so that it can go into 2.6.31.y and 2.6.32.y.

Andrew, if you'd rather send it to Linus right now since it is an obvious
one-char fix, well, I'd not oppose it at all :-)

> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index d93108d..03c0a56 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -6313,7 +6313,7 @@ static int brightness_write(char *buf)
>  	 * Doing it this way makes the syscall restartable in case of EINTR
>  	 */
>  	rc = brightness_set(level);
> -	return (rc == -EINTR)? ERESTARTSYS : rc;
> +	return (rc == -EINTR)? -ERESTARTSYS : rc;
>  }
>  
>  static struct ibm_struct brightness_driver_data = {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [PATCH] thinkpad-acpi: should error return be nagative?

[Len Brown]

applied

thanks,
Len Brown, Intel Open Source Technology Center