* [PATCH] dasd: PTR_ERR return of wrong pointer in dasd_alias_make_device_known_to_lcu()
@ 2009-12-07 13:18 Roel Kluin
2009-12-07 13:22 ` Martin Schwidefsky
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-12-07 13:18 UTC (permalink / raw)
To: Andrew Morton, LKML, wein, schwidefsky
Return the PTR_ERR of the correct pointer.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/s390/block/dasd_alias.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Unless I am mistaken?
diff --git a/drivers/s390/block/dasd_alias.c b/drivers/s390/block/dasd_alias.c
index 70a008c..fa37148 100644
--- a/drivers/s390/block/dasd_alias.c
+++ b/drivers/s390/block/dasd_alias.c
@@ -217,7 +217,7 @@ int dasd_alias_make_device_known_to_lcu(struct dasd_device *device)
spin_unlock_irqrestore(&aliastree.lock, flags);
newlcu = _allocate_lcu(uid);
if (IS_ERR(newlcu))
- return PTR_ERR(lcu);
+ return PTR_ERR(newlcu);
spin_lock_irqsave(&aliastree.lock, flags);
lcu = _find_lcu(server, uid);
if (!lcu) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dasd: PTR_ERR return of wrong pointer in dasd_alias_make_device_known_to_lcu()
2009-12-07 13:18 [PATCH] dasd: PTR_ERR return of wrong pointer in dasd_alias_make_device_known_to_lcu() Roel Kluin
@ 2009-12-07 13:22 ` Martin Schwidefsky
0 siblings, 0 replies; 2+ messages in thread
From: Martin Schwidefsky @ 2009-12-07 13:22 UTC (permalink / raw)
To: Roel Kluin; +Cc: Andrew Morton, LKML, wein
On Mon, 07 Dec 2009 14:18:40 +0100
Roel Kluin <roel.kluin@gmail.com> wrote:
> Return the PTR_ERR of the correct pointer.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/s390/block/dasd_alias.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Unless I am mistaken?
>
> diff --git a/drivers/s390/block/dasd_alias.c b/drivers/s390/block/dasd_alias.c
> index 70a008c..fa37148 100644
> --- a/drivers/s390/block/dasd_alias.c
> +++ b/drivers/s390/block/dasd_alias.c
> @@ -217,7 +217,7 @@ int dasd_alias_make_device_known_to_lcu(struct dasd_device *device)
> spin_unlock_irqrestore(&aliastree.lock, flags);
> newlcu = _allocate_lcu(uid);
> if (IS_ERR(newlcu))
> - return PTR_ERR(lcu);
> + return PTR_ERR(newlcu);
> spin_lock_irqsave(&aliastree.lock, flags);
> lcu = _find_lcu(server, uid);
> if (!lcu) {
You are not mistaken. I'll add the patch to the queue. Thanks.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-07 13:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-07 13:18 [PATCH] dasd: PTR_ERR return of wrong pointer in dasd_alias_make_device_known_to_lcu() Roel Kluin
2009-12-07 13:22 ` Martin Schwidefsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox