* [PATCH] [NETLINK]: With opcode INET_DIAG_BC_S_LE dport was compared in inet_diag_bc_run()
@ 2010-01-19 21:50 Roel Kluin
2010-01-19 22:12 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-01-19 21:50 UTC (permalink / raw)
To: David S. Miller, netdev, Andrew Morton, Alexey Kuznetsov,
James Morris, Patrick McHardy, LKML
The s-port should be compared.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
I presume?
diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
index bdb78dd..1aaa811 100644
--- a/net/ipv4/inet_diag.c
+++ b/net/ipv4/inet_diag.c
@@ -368,7 +368,7 @@ static int inet_diag_bc_run(const void *bc, int len,
yes = entry->sport >= op[1].no;
break;
case INET_DIAG_BC_S_LE:
- yes = entry->dport <= op[1].no;
+ yes = entry->sport <= op[1].no;
break;
case INET_DIAG_BC_D_GE:
yes = entry->dport >= op[1].no;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [NETLINK]: With opcode INET_DIAG_BC_S_LE dport was compared in inet_diag_bc_run()
2010-01-19 21:50 [PATCH] [NETLINK]: With opcode INET_DIAG_BC_S_LE dport was compared in inet_diag_bc_run() Roel Kluin
@ 2010-01-19 22:12 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-01-19 22:12 UTC (permalink / raw)
To: roel.kluin; +Cc: netdev, akpm, kuznet, jmorris, kaber, linux-kernel
From: Roel Kluin <roel.kluin@gmail.com>
Date: Tue, 19 Jan 2010 22:50:21 +0100
> The s-port should be compared.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> I presume?
Yep, looks good.
Excellent catch, applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-19 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-19 21:50 [PATCH] [NETLINK]: With opcode INET_DIAG_BC_S_LE dport was compared in inet_diag_bc_run() Roel Kluin
2010-01-19 22:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox