public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@kernel.org>
To: Sitsofe Wheeler <sitsofe@yahoo.com>
Cc: Sven Joachim <svenjoac@gmx.de>, Hugh Dickins <hughd@google.com>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] Revert "drm/i915: fix vblank wait test condition"
Date: Sun, 05 Sep 2010 10:58:45 +0300	[thread overview]
Message-ID: <4C834DB5.3070702@kernel.org> (raw)
In-Reply-To: <20100904224453.GA31664@sucs.org>

  On 5.9.2010 1.44, Sitsofe Wheeler wrote:
> On Sat, Sep 04, 2010 at 10:42:46PM +0200, Sven Joachim wrote:
>> On 2010-09-04 21:54 +0200, Hugh Dickins wrote:
>>
>>> On Sat, 4 Sep 2010, Pekka Enberg wrote:
>>>> On Sat,  4 Sep 2010 11:17:14 +0300, Pekka Enberg<penberg@kernel.org>  wrote:
>>>>>> This reverts commit 9559fcdbff4f93d29af04478bbc48294519424f5. The commit causes
>>>>>> wrong screen resolution on some i915 machines such as MacBook which is a
>>>>>> regression from 2.6.35. The issue has been reported multiple times but no fix
>>>>>> has emerged:
>>>> On Sat, Sep 4, 2010 at 12:21 PM, Chris Wilson<chris@chris-wilson.co.uk>  wrote:
>>>>> NAK. You can't simply hide one bug by introducing a much bigger one.
>>>> Dude, it's a nasty regression from 2.6.35. What exactly are you NAK'ing here?
>>>>
>>>>> As you have an affected machine, find which wait_for_vblank() needs to be
>>>>> replaced with a msleep(20|50).
>>>> The attached patch fixes things here. I'm not a drm developer so I
>>>> don't know if it makes technical sense.
>>> Many thanks to you, Pekka: I also don't know if it makes technical sense,
>>> but it solves the same issue for me, so I can at last use 2.6.36-rc on
>>> this laptop.
>> Helps for me as well, but I cannot judge whether it makes technical
>> sense either.  Thanks, Pekka!
> Sadly this doesn't help my EeePC 900 with an i915 when it is booted with
> a battery inside or after doing a suspend to ram (running
> modetest/xrandr in these situations says VGA is connected when there
> isn't even a cable attached).
I haven't heard of this problem. Is it reported on LKML? Is it a 
regression from 2.6.35?

             Pekka

  reply	other threads:[~2010-09-05  8:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-04  8:17 [PATCH] Revert "drm/i915: fix vblank wait test condition" Pekka Enberg
2010-09-04  9:21 ` Chris Wilson
2010-09-04 16:29   ` Pekka Enberg
2010-09-04 19:54     ` Hugh Dickins
2010-09-04 20:42       ` Sven Joachim
2010-09-04 22:44         ` Sitsofe Wheeler
2010-09-05  7:58           ` Pekka Enberg [this message]
2010-09-05  9:37             ` Sitsofe Wheeler
2010-09-05  8:26           ` Fabio Comolli
2010-09-05  9:14             ` Sitsofe Wheeler
2010-09-05 10:13               ` Fabio Comolli
2010-09-05 10:21                 ` Fabio Comolli
2010-09-05 12:27                   ` Sitsofe Wheeler
2010-09-05 17:41                     ` Fabio Comolli
2010-09-05 16:11         ` Pekka Enberg
2010-09-05 16:23           ` Chris Wilson
2010-09-05 16:40             ` Pekka Enberg
2010-09-05 17:21               ` Chris Wilson
2010-09-05 17:26                 ` Pekka Enberg
2010-09-05 17:53                 ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C834DB5.3070702@kernel.org \
    --to=penberg@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=hughd@google.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sitsofe@yahoo.com \
    --cc=svenjoac@gmx.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox