public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@kernel.org>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Pekka Enberg <penberg@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Sitsofe Wheeler <sitsofe@yahoo.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: [PATCH] Revert "drm/i915: fix vblank wait test condition"
Date: Sat,  4 Sep 2010 11:17:14 +0300	[thread overview]
Message-ID: <1283588234-2514-1-git-send-email-penberg@kernel.org> (raw)

This reverts commit 9559fcdbff4f93d29af04478bbc48294519424f5. The commit causes
wrong screen resolution on some i915 machines such as MacBook which is a
regression from 2.6.35. The issue has been reported multiple times but no fix
has emerged:

  - i915: 2.6.36-rc2 wrong resolution on gdm start:
    http://lkml.org/lkml/2010/8/23/452

  - i915: wrong framebuffer size in 2.6.36-rc3
    http://kerneltrap.org/mailarchive/linux-kernel/2010/8/30/4613057

I think it's time to revert the commit and try again in 2.6.37.

Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Sitsofe Wheeler <sitsofe@yahoo.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Reported-by Ivan Bulatovic <combuster@gmx.com>
Reported-by: Pekka Enberg <penberg@kernel.org>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 11a3394..23157e1 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -992,7 +992,7 @@ void intel_wait_for_vblank(struct drm_device *dev, int pipe)
 
 	/* Wait for vblank interrupt bit to set */
 	if (wait_for((I915_READ(pipestat_reg) &
-		      PIPE_VBLANK_INTERRUPT_STATUS),
+		      PIPE_VBLANK_INTERRUPT_STATUS) == 0,
 		     50, 0))
 		DRM_DEBUG_KMS("vblank wait timed out\n");
 }
-- 
1.6.3.3


             reply	other threads:[~2010-09-04  8:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-04  8:17 Pekka Enberg [this message]
2010-09-04  9:21 ` [PATCH] Revert "drm/i915: fix vblank wait test condition" Chris Wilson
2010-09-04 16:29   ` Pekka Enberg
2010-09-04 19:54     ` Hugh Dickins
2010-09-04 20:42       ` Sven Joachim
2010-09-04 22:44         ` Sitsofe Wheeler
2010-09-05  7:58           ` Pekka Enberg
2010-09-05  9:37             ` Sitsofe Wheeler
2010-09-05  8:26           ` Fabio Comolli
2010-09-05  9:14             ` Sitsofe Wheeler
2010-09-05 10:13               ` Fabio Comolli
2010-09-05 10:21                 ` Fabio Comolli
2010-09-05 12:27                   ` Sitsofe Wheeler
2010-09-05 17:41                     ` Fabio Comolli
2010-09-05 16:11         ` Pekka Enberg
2010-09-05 16:23           ` Chris Wilson
2010-09-05 16:40             ` Pekka Enberg
2010-09-05 17:21               ` Chris Wilson
2010-09-05 17:26                 ` Pekka Enberg
2010-09-05 17:53                 ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283588234-2514-1-git-send-email-penberg@kernel.org \
    --to=penberg@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sitsofe@yahoo.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox