From: Cong Wang <amwang@redhat.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Eric Biederman <ebiederm@xmission.com>,
kexec@lists.infradead.org, Eric Paris <eparis@redhat.com>
Subject: Re: [Patch] kexec_load: check CAP_SYS_MODULE
Date: Thu, 06 Jan 2011 16:27:17 +0800 [thread overview]
Message-ID: <4D257CE5.1030001@redhat.com> (raw)
In-Reply-To: <1294302325-22593-1-git-send-email-amwang@redhat.com>
(Forgot Cc'ing Eric Paris, adding.)
> Eric pointed out that kexec_load() actually allows you to
> run any code you want in ring0, this is more like CAP_SYS_MODULE.
>
> Reported-by: Eric Paris<eparis@redhat.com>
> Signed-off-by: WANG Cong<amwang@redhat.com>
>
> ---
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index b55045b..c30d613 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -945,7 +945,7 @@ SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments,
> int result;
>
> /* We only trust the superuser with rebooting the system. */
> - if (!capable(CAP_SYS_BOOT))
> + if (!capable(CAP_SYS_BOOT) || !capable(CAP_SYS_MODULE))
> return -EPERM;
>
> /*
next prev parent reply other threads:[~2011-01-06 8:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 8:25 [Patch] kexec_load: check CAP_SYS_MODULE Amerigo Wang
2011-01-06 8:27 ` Cong Wang [this message]
2011-01-06 8:47 ` Eric W. Biederman
2011-01-06 19:02 ` Eric Paris
2011-01-07 20:10 ` Eric W. Biederman
2011-01-07 20:32 ` Eric Paris
2011-01-07 21:02 ` Eric W. Biederman
2011-01-08 0:39 ` Eric Paris
2011-01-09 2:09 ` Eric W. Biederman
2011-01-11 11:26 ` Cong Wang
2011-01-14 19:47 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D257CE5.1030001@redhat.com \
--to=amwang@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox