public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Eric Paris <eparis@redhat.com>,
	linux-kernel@vger.kernel.org, kexec@lists.infradead.org
Subject: Re: [Patch] kexec_load: check CAP_SYS_MODULE
Date: Tue, 11 Jan 2011 19:26:05 +0800	[thread overview]
Message-ID: <4D2C3E4D.3070307@redhat.com> (raw)
In-Reply-To: <m1k4ieesky.fsf@fess.ebiederm.org>

于 2011年01月09日 10:09, Eric W. Biederman 写道:
>
> We aren't dealing with modules I think CAP_SYS_MODULE is totally
> irrelevant in the context of kexec.


Yeah, although I don't really understand CAP_SYS_MODULE, but it
really confused me to add it to kexec_load() from its name.

>
> I think to accomplish what you want we either need a way to disable
> sys_kexec_load or possibly a new very targeted capability bit.
>
> You are making it so that giving someone CAP_SYS_MODULE is giving more
> than the ability to load kernel modules.  Which seems non-intuitive from
> a system management point of view.
>

How about CAP_SYS_KEXEC?

Thanks.

  reply	other threads:[~2011-01-11 11:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06  8:25 [Patch] kexec_load: check CAP_SYS_MODULE Amerigo Wang
2011-01-06  8:27 ` Cong Wang
2011-01-06  8:47 ` Eric W. Biederman
2011-01-06 19:02   ` Eric Paris
2011-01-07 20:10     ` Eric W. Biederman
2011-01-07 20:32       ` Eric Paris
2011-01-07 21:02         ` Eric W. Biederman
2011-01-08  0:39           ` Eric Paris
2011-01-09  2:09             ` Eric W. Biederman
2011-01-11 11:26               ` Cong Wang [this message]
2011-01-14 19:47               ` Eric Paris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2C3E4D.3070307@redhat.com \
    --to=amwang@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=eparis@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox