* /proc/kcore: fix seeking
@ 2011-01-10 14:17 Dave Anderson
0 siblings, 0 replies; only message in thread
From: Dave Anderson @ 2011-01-10 14:17 UTC (permalink / raw)
To: linux-kernel; +Cc: fweisbec
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
From: Dave Anderson <anderson@redhat.com>
Commit 34aacb2920667d405a8df15968b7f71ba46c8f18
("procfs: Use generic_file_llseek in /proc/kcore")
broke seeking on /proc/kcore. This changes it back
to use default_llseek in order to restore the original
behavior.
The problem with generic_file_llseek is that it only
allows seeks up to inode->i_sb->s_maxbytes, which is
2GB-1 on procfs, where the memory file offset values in
the /proc/kcore PT_LOAD segments may exceed or start
beyond that offset value.
A similar revert was made for /proc/vmcore.
Signed-off-by: Dave Anderson <anderson@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
---
[-- Attachment #2: kcore.patch --]
[-- Type: text/x-patch, Size: 340 bytes --]
--- linux-2.6.37/fs/proc/kcore.c.orig
+++ linux-2.6.37/fs/proc/kcore.c
@@ -558,7 +558,7 @@ static int open_kcore(struct inode *inod
static const struct file_operations proc_kcore_operations = {
.read = read_kcore,
.open = open_kcore,
- .llseek = generic_file_llseek,
+ .llseek = default_llseek,
};
#ifdef CONFIG_MEMORY_HOTPLUG
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-01-10 14:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-10 14:17 /proc/kcore: fix seeking Dave Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox