public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: wwang <wei_wang@realsil.com.cn>
To: 王炜 <wei_wang@realsil.com.cn>
Cc: "gregkh@suse.de" <gregkh@suse.de>,
	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix a miswriting in ext_sd_send_cmd_get_rsp
Date: Mon, 11 Jul 2011 10:18:55 +0800	[thread overview]
Message-ID: <4E1A5D8F.2020600@realsil.com.cn> (raw)
In-Reply-To: <1310350393-6261-1-git-send-email-wei_wang@realsil.com.cn>

On 2011年07月11日 10:13, 王炜 wrote:
> From: wwang<wei_wang@realsil.com.cn>
>
> cppcheck reported: [staging/rts_pstor/sd.c:3730] ->  [staging/rts_pstor/sd.c:3726]: (style) Found duplicate if expressions.
> It's a miswriting, and the second if expression should be "(rsp_type == SD_RSP_TYPE_R0)"
>
> Signed-off-by: wwang<wei_wang@realsil.com.cn>
> ---
>   drivers/staging/rts_pstor/sd.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
> index e4b3891..8db14dd 100644
> --- a/drivers/staging/rts_pstor/sd.c
> +++ b/drivers/staging/rts_pstor/sd.c
> @@ -3747,7 +3747,7 @@ RTY_SEND_CMD:
>   				if ((ptr[3]&  0x1E) != 0x04) {
>   					TRACE_RET(chip, STATUS_FAIL);
>   				}
> -			} else if (rsp_type == SD_RSP_TYPE_R2) {
> +			} else if (rsp_type == SD_RSP_TYPE_R0) {
>   				if ((ptr[3]&  0x1E) != 0x03) {
>   					TRACE_RET(chip, STATUS_FAIL);
>   				}

Dear all:

     Sorry to bother, please ignore this mail, I will modify the log 
resend again.

     Best regards,
     wwang


      reply	other threads:[~2011-07-11  2:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11  2:13 [PATCH] Fix a miswriting in ext_sd_send_cmd_get_rsp wei_wang
2011-07-11  2:18 ` wwang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1A5D8F.2020600@realsil.com.cn \
    --to=wei_wang@realsil.com.cn \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox