* [PATCH] Fix a miswriting in ext_sd_send_cmd_get_rsp
@ 2011-07-11 2:13 wei_wang
2011-07-11 2:18 ` wwang
0 siblings, 1 reply; 2+ messages in thread
From: wei_wang @ 2011-07-11 2:13 UTC (permalink / raw)
To: gregkh, devel, linux-kernel; +Cc: wwang
From: wwang <wei_wang@realsil.com.cn>
cppcheck reported: [staging/rts_pstor/sd.c:3730] -> [staging/rts_pstor/sd.c:3726]: (style) Found duplicate if expressions.
It's a miswriting, and the second if expression should be "(rsp_type == SD_RSP_TYPE_R0)"
Signed-off-by: wwang <wei_wang@realsil.com.cn>
---
drivers/staging/rts_pstor/sd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
index e4b3891..8db14dd 100644
--- a/drivers/staging/rts_pstor/sd.c
+++ b/drivers/staging/rts_pstor/sd.c
@@ -3747,7 +3747,7 @@ RTY_SEND_CMD:
if ((ptr[3] & 0x1E) != 0x04) {
TRACE_RET(chip, STATUS_FAIL);
}
- } else if (rsp_type == SD_RSP_TYPE_R2) {
+ } else if (rsp_type == SD_RSP_TYPE_R0) {
if ((ptr[3] & 0x1E) != 0x03) {
TRACE_RET(chip, STATUS_FAIL);
}
--
1.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Fix a miswriting in ext_sd_send_cmd_get_rsp
2011-07-11 2:13 [PATCH] Fix a miswriting in ext_sd_send_cmd_get_rsp wei_wang
@ 2011-07-11 2:18 ` wwang
0 siblings, 0 replies; 2+ messages in thread
From: wwang @ 2011-07-11 2:18 UTC (permalink / raw)
To: 王炜
Cc: gregkh@suse.de, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
On 2011年07月11日 10:13, 王炜 wrote:
> From: wwang<wei_wang@realsil.com.cn>
>
> cppcheck reported: [staging/rts_pstor/sd.c:3730] -> [staging/rts_pstor/sd.c:3726]: (style) Found duplicate if expressions.
> It's a miswriting, and the second if expression should be "(rsp_type == SD_RSP_TYPE_R0)"
>
> Signed-off-by: wwang<wei_wang@realsil.com.cn>
> ---
> drivers/staging/rts_pstor/sd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
> index e4b3891..8db14dd 100644
> --- a/drivers/staging/rts_pstor/sd.c
> +++ b/drivers/staging/rts_pstor/sd.c
> @@ -3747,7 +3747,7 @@ RTY_SEND_CMD:
> if ((ptr[3]& 0x1E) != 0x04) {
> TRACE_RET(chip, STATUS_FAIL);
> }
> - } else if (rsp_type == SD_RSP_TYPE_R2) {
> + } else if (rsp_type == SD_RSP_TYPE_R0) {
> if ((ptr[3]& 0x1E) != 0x03) {
> TRACE_RET(chip, STATUS_FAIL);
> }
Dear all:
Sorry to bother, please ignore this mail, I will modify the log
resend again.
Best regards,
wwang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-11 2:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-11 2:13 [PATCH] Fix a miswriting in ext_sd_send_cmd_get_rsp wei_wang
2011-07-11 2:18 ` wwang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox