From: Jarod Wilson <jarod@redhat.com>
To: stufever@gmail.com
Cc: linux-kernel@vger.kernel.org, mchehab@infradead.org,
"Wang Shaoyan" <wangshaoyan.pt@taobao.com>,
"David Härdeman" <david@hardeman.nu>
Subject: Re: [PATCH] media: declare redrat3_init_rc_dev with the same parameter types
Date: Mon, 08 Aug 2011 17:30:06 -0400 [thread overview]
Message-ID: <4E40555E.90904@redhat.com> (raw)
In-Reply-To: <1312651155-21891-1-git-send-email-wangshaoyan.pt@taobao.com>
stufever@gmail.com wrote:
> From: Wang Shaoyan<wangshaoyan.pt@taobao.com>
>
> drivers/media/rc/redrat3.c: In function 'redrat3_init_rc_dev':
> drivers/media/rc/redrat3.c:1107: warning: assignment from incompatible pointer type
>
> Signed-off-by: Wang Shaoyan<wangshaoyan.pt@taobao.com>
> ---
> drivers/media/rc/redrat3.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
> index a166044..332ffa4 100644
> --- a/drivers/media/rc/redrat3.c
> +++ b/drivers/media/rc/redrat3.c
> @@ -912,7 +912,7 @@ static int redrat3_set_tx_carrier(struct rc_dev *dev, u32 carrier)
> return carrier;
> }
>
> -static int redrat3_transmit_ir(struct rc_dev *rcdev, int *txbuf, u32 n)
> +static int redrat3_transmit_ir(struct rc_dev *rcdev, unsigned *txbuf, unsigned n)
> {
> struct redrat3_dev *rr3 = rcdev->priv;
> struct device *dev = rr3->dev;
Not sure if this change is complete. See the mceusb.c changes in commit
5588dc2b025fd8b2188142b8d59efe562bd57d80. Fixing this is on my TODO
list, and I have the hardware to test, just haven't got to it yet.
Actually, I have a patch that closely matches the referenced mceusb.c
changes now, I just need to test it out...
--
Jarod Wilson
jarod@redhat.com
prev parent reply other threads:[~2011-08-08 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 17:19 [PATCH] media: declare redrat3_init_rc_dev with the same parameter types stufever
2011-08-08 21:30 ` Jarod Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E40555E.90904@redhat.com \
--to=jarod@redhat.com \
--cc=david@hardeman.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=stufever@gmail.com \
--cc=wangshaoyan.pt@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox