* [PATCH] media: declare redrat3_init_rc_dev with the same parameter types
@ 2011-08-06 17:19 stufever
2011-08-08 21:30 ` Jarod Wilson
0 siblings, 1 reply; 2+ messages in thread
From: stufever @ 2011-08-06 17:19 UTC (permalink / raw)
To: linux-kernel; +Cc: mchehab, jarod, Wang Shaoyan
From: Wang Shaoyan <wangshaoyan.pt@taobao.com>
drivers/media/rc/redrat3.c: In function 'redrat3_init_rc_dev':
drivers/media/rc/redrat3.c:1107: warning: assignment from incompatible pointer type
Signed-off-by: Wang Shaoyan <wangshaoyan.pt@taobao.com>
---
drivers/media/rc/redrat3.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
index a166044..332ffa4 100644
--- a/drivers/media/rc/redrat3.c
+++ b/drivers/media/rc/redrat3.c
@@ -912,7 +912,7 @@ static int redrat3_set_tx_carrier(struct rc_dev *dev, u32 carrier)
return carrier;
}
-static int redrat3_transmit_ir(struct rc_dev *rcdev, int *txbuf, u32 n)
+static int redrat3_transmit_ir(struct rc_dev *rcdev, unsigned *txbuf, unsigned n)
{
struct redrat3_dev *rr3 = rcdev->priv;
struct device *dev = rr3->dev;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: declare redrat3_init_rc_dev with the same parameter types
2011-08-06 17:19 [PATCH] media: declare redrat3_init_rc_dev with the same parameter types stufever
@ 2011-08-08 21:30 ` Jarod Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Jarod Wilson @ 2011-08-08 21:30 UTC (permalink / raw)
To: stufever; +Cc: linux-kernel, mchehab, Wang Shaoyan, David Härdeman
stufever@gmail.com wrote:
> From: Wang Shaoyan<wangshaoyan.pt@taobao.com>
>
> drivers/media/rc/redrat3.c: In function 'redrat3_init_rc_dev':
> drivers/media/rc/redrat3.c:1107: warning: assignment from incompatible pointer type
>
> Signed-off-by: Wang Shaoyan<wangshaoyan.pt@taobao.com>
> ---
> drivers/media/rc/redrat3.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
> index a166044..332ffa4 100644
> --- a/drivers/media/rc/redrat3.c
> +++ b/drivers/media/rc/redrat3.c
> @@ -912,7 +912,7 @@ static int redrat3_set_tx_carrier(struct rc_dev *dev, u32 carrier)
> return carrier;
> }
>
> -static int redrat3_transmit_ir(struct rc_dev *rcdev, int *txbuf, u32 n)
> +static int redrat3_transmit_ir(struct rc_dev *rcdev, unsigned *txbuf, unsigned n)
> {
> struct redrat3_dev *rr3 = rcdev->priv;
> struct device *dev = rr3->dev;
Not sure if this change is complete. See the mceusb.c changes in commit
5588dc2b025fd8b2188142b8d59efe562bd57d80. Fixing this is on my TODO
list, and I have the hardware to test, just haven't got to it yet.
Actually, I have a patch that closely matches the referenced mceusb.c
changes now, I just need to test it out...
--
Jarod Wilson
jarod@redhat.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-08 21:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-06 17:19 [PATCH] media: declare redrat3_init_rc_dev with the same parameter types stufever
2011-08-08 21:30 ` Jarod Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox