* [patch v5 resending 5/5] crc32: fix-check-endian-warnings.diff
@ 2011-08-11 17:41 Bob Pearson
0 siblings, 0 replies; only message in thread
From: Bob Pearson @ 2011-08-11 17:41 UTC (permalink / raw)
To: linux-kernel, joakim.tjernlund, akpm, linux, fzago
crc32.c freely mixes u32, __le32 and __be32 types. Fix warnings from
sparse with "-D__CHECK_ENDIAN__" by some emphatic casts.
Signed-off-by: Bob Pearson <rpearson@systemfabricworks.com>
---
lib/crc32.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
Index: infiniband/lib/crc32.c
===================================================================
--- infiniband.orig/lib/crc32.c
+++ infiniband/lib/crc32.c
@@ -26,13 +26,13 @@
#include "crc32defs.h"
#if CRC_LE_BITS == 8
-# define tole(x) __constant_cpu_to_le32(x)
+# define tole(x) (__force u32) __constant_cpu_to_le32(x)
#else
# define tole(x) (x)
#endif
#if CRC_BE_BITS == 8
-# define tobe(x) __constant_cpu_to_be32(x)
+# define tobe(x) (__force u32) __constant_cpu_to_be32(x)
#else
# define tobe(x) (x)
#endif
@@ -126,9 +126,9 @@ u32 __pure crc32_le(u32 crc, unsigned ch
# elif CRC_LE_BITS == 8
const u32 (*tab)[] = crc32table_le;
- crc = __cpu_to_le32(crc);
+ crc = (__force u32) __cpu_to_le32(crc);
crc = crc32_body(crc, p, len, tab);
- crc = __le32_to_cpu(crc);
+ crc = __le32_to_cpu((__force __le32)crc);
#endif
return crc;
}
@@ -169,9 +169,9 @@ u32 __pure crc32_be(u32 crc, unsigned ch
# elif CRC_BE_BITS == 8
const u32 (*tab)[] = crc32table_be;
- crc = __cpu_to_be32(crc);
+ crc = (__force u32) __cpu_to_be32(crc);
crc = crc32_body(crc, p, len, tab);
- crc = __be32_to_cpu(crc);
+ crc = __be32_to_cpu((__force __be32)crc);
# endif
return crc;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-08-11 17:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-11 17:41 [patch v5 resending 5/5] crc32: fix-check-endian-warnings.diff Bob Pearson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox