* [PATCH] exofs/super.c: local functions should be static
@ 2011-09-23 20:46 H Hartley Sweeten
2011-10-03 9:24 ` Boaz Harrosh
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2011-09-23 20:46 UTC (permalink / raw)
To: Linux Kernel; +Cc: osd-dev, bharrosh, bhalevy
This quiets the following sparse noise:
warning: symbol 'exofs_sync_fs' was not declared. Should it be static?
warning: symbol 'exofs_free_sbi' was not declared. Should it be static?
warning: symbol 'exofs_get_parent' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Boaz Harrosh <bharrosh@panasas.com>
Cc: Benny Halevy <bhalevy@panasas.com>
---
diff --git a/fs/exofs/super.c b/fs/exofs/super.c
index 9049e27..8c900d4 100644
--- a/fs/exofs/super.c
+++ b/fs/exofs/super.c
@@ -356,7 +356,7 @@ static const struct export_operations exofs_export_ops;
/*
* Write the superblock to the OSD
*/
-int exofs_sync_fs(struct super_block *sb, int wait)
+static int exofs_sync_fs(struct super_block *sb, int wait)
{
struct exofs_sb_info *sbi;
struct exofs_fscb *fscb;
@@ -430,7 +430,7 @@ static void _exofs_print_device(const char *msg, const char *dev_path,
msg, dev_path ?: "", odi->osdname, _LLU(pid));
}
-void exofs_free_sbi(struct exofs_sb_info *sbi)
+static void exofs_free_sbi(struct exofs_sb_info *sbi)
{
while (sbi->comps.numdevs) {
int i = --sbi->comps.numdevs;
@@ -969,7 +969,7 @@ static const struct super_operations exofs_sops = {
* EXPORT OPERATIONS
*****************************************************************************/
-struct dentry *exofs_get_parent(struct dentry *child)
+static struct dentry *exofs_get_parent(struct dentry *child)
{
unsigned long ino = exofs_parent_ino(child);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] exofs/super.c: local functions should be static
2011-09-23 20:46 [PATCH] exofs/super.c: local functions should be static H Hartley Sweeten
@ 2011-10-03 9:24 ` Boaz Harrosh
0 siblings, 0 replies; 2+ messages in thread
From: Boaz Harrosh @ 2011-10-03 9:24 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, osd-dev, bhalevy
On 09/23/2011 11:46 PM, H Hartley Sweeten wrote:
> This quiets the following sparse noise:
>
> warning: symbol 'exofs_sync_fs' was not declared. Should it be static?
> warning: symbol 'exofs_free_sbi' was not declared. Should it be static?
> warning: symbol 'exofs_get_parent' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Boaz Harrosh <bharrosh@panasas.com>
> Cc: Benny Halevy <bhalevy@panasas.com>
>
Both patches are in linux-next for the next merge window
Thanks Hartley
Boaz
> ---
>
> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
> index 9049e27..8c900d4 100644
> --- a/fs/exofs/super.c
> +++ b/fs/exofs/super.c
> @@ -356,7 +356,7 @@ static const struct export_operations exofs_export_ops;
> /*
> * Write the superblock to the OSD
> */
> -int exofs_sync_fs(struct super_block *sb, int wait)
> +static int exofs_sync_fs(struct super_block *sb, int wait)
> {
> struct exofs_sb_info *sbi;
> struct exofs_fscb *fscb;
> @@ -430,7 +430,7 @@ static void _exofs_print_device(const char *msg, const char *dev_path,
> msg, dev_path ?: "", odi->osdname, _LLU(pid));
> }
>
> -void exofs_free_sbi(struct exofs_sb_info *sbi)
> +static void exofs_free_sbi(struct exofs_sb_info *sbi)
> {
> while (sbi->comps.numdevs) {
> int i = --sbi->comps.numdevs;
> @@ -969,7 +969,7 @@ static const struct super_operations exofs_sops = {
> * EXPORT OPERATIONS
> *****************************************************************************/
>
> -struct dentry *exofs_get_parent(struct dentry *child)
> +static struct dentry *exofs_get_parent(struct dentry *child)
> {
> unsigned long ino = exofs_parent_ino(child);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-03 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-23 20:46 [PATCH] exofs/super.c: local functions should be static H Hartley Sweeten
2011-10-03 9:24 ` Boaz Harrosh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox