[Resend 2x] thermal: Prevent polling from happening during system suspend

[Resend 2x] thermal: Prevent polling from happening during system suspend

[Rafael J. Wysocki]

From: Rafael J. Wysocki <rjw@sisk.pl>

The thermal driver should use a freezable workqueue to schedule
polling to prevent thermal_zone_device_update() from being run
during system suspend, when the devices it relies on may be inactive.
Make it use the system freezable workqueue for this purpose.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 drivers/thermal/thermal_sys.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/drivers/thermal/thermal_sys.c
===================================================================
--- linux.orig/drivers/thermal/thermal_sys.c
+++ linux/drivers/thermal/thermal_sys.c
@@ -678,10 +678,10 @@ static void thermal_zone_device_set_poll
 		return;
 
 	if (delay > 1000)
-		schedule_delayed_work(&(tz->poll_queue),
+		queue_delayed_work(system_freezable_wq, &(tz->poll_queue),
 				      round_jiffies(msecs_to_jiffies(delay)));
 	else
-		schedule_delayed_work(&(tz->poll_queue),
+		queue_delayed_work(system_freezable_wq, &(tz->poll_queue),
 				      msecs_to_jiffies(delay));
 }
 

Re: [Resend 2x] thermal: Prevent polling from happening during system suspend

[Len Brown]

Applied.

thanks,
Len Brown, Intel Open Source Technology Center

Re: [Resend 2x] thermal: Prevent polling from happening during system suspend

[Pavel Machek]

On Sun 2011-11-06 14:21:38, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
> 
> The thermal driver should use a freezable workqueue to schedule
> polling to prevent thermal_zone_device_update() from being run
> during system suspend, when the devices it relies on may be inactive.
> Make it use the system freezable workqueue for this purpose.

Umm. hibernation can take long time and (with latest compression
patches) can be CPU intensive.

Is it good idea to disable thermal management?

Should we kick fans to full speed before starting hibernation?
								Pavel

> @@ -678,10 +678,10 @@ static void thermal_zone_device_set_poll
>  		return;
>  
>  	if (delay > 1000)
> -		schedule_delayed_work(&(tz->poll_queue),
> +		queue_delayed_work(system_freezable_wq, &(tz->poll_queue),
>  				      round_jiffies(msecs_to_jiffies(delay)));
>  	else
> -		schedule_delayed_work(&(tz->poll_queue),
> +		queue_delayed_work(system_freezable_wq, &(tz->poll_queue),
>  				      msecs_to_jiffies(delay));
>  }

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html