[PATCH] PCI / Hotplug: Fix the ordering of operations in pcied_cleanup()

[PATCH] PCI / Hotplug: Fix the ordering of operations in pcied_cleanup()

[Rafael J. Wysocki]

From: Rafael J. Wysocki <rjw@sisk.pl>

Make pcied_cleanup() unregister the port service before
destroying workqueues that are flushed during the port service
unregistration.

Reported-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 drivers/pci/hotplug/pciehp_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/pci/hotplug/pciehp_core.c
===================================================================
--- linux.orig/drivers/pci/hotplug/pciehp_core.c
+++ linux/drivers/pci/hotplug/pciehp_core.c
@@ -366,9 +366,9 @@ static int __init pcied_init(void)
 static void __exit pcied_cleanup(void)
 {
 	dbg("unload_pciehpd()\n");
+	pcie_port_service_unregister(&hpdriver_portdrv);
 	destroy_workqueue(pciehp_ordered_wq);
 	destroy_workqueue(pciehp_wq);
-	pcie_port_service_unregister(&hpdriver_portdrv);
 	info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n");
 }
 

Re: [PATCH] PCI / Hotplug: Fix the ordering of operations in pcied_cleanup()

[Kenji Kaneshige]

I've sent the patch to fix the problem a few weeks ago, and it is in
Jesse's -next tree.

Regards,
Kenji Kaneshige


(2011/11/23 7:05), Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki<rjw@sisk.pl>
> 
> Make pcied_cleanup() unregister the port service before
> destroying workqueues that are flushed during the port service
> unregistration.
> 
> Reported-by: Oliver Neukum<oneukum@suse.de>
> Signed-off-by: Rafael J. Wysocki<rjw@sisk.pl>
> ---
>   drivers/pci/hotplug/pciehp_core.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux/drivers/pci/hotplug/pciehp_core.c
> ===================================================================
> --- linux.orig/drivers/pci/hotplug/pciehp_core.c
> +++ linux/drivers/pci/hotplug/pciehp_core.c
> @@ -366,9 +366,9 @@ static int __init pcied_init(void)
>   static void __exit pcied_cleanup(void)
>   {
>   	dbg("unload_pciehpd()\n");
> +	pcie_port_service_unregister(&hpdriver_portdrv);
>   	destroy_workqueue(pciehp_ordered_wq);
>   	destroy_workqueue(pciehp_wq);
> -	pcie_port_service_unregister(&hpdriver_portdrv);
>   	info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n");
>   }
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>