From: Jinyoung Park <jinyoungp@nvidia.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 1/4] mfd: aat2870-core: Use gpio_request_one
Date: Thu, 1 Dec 2011 17:38:18 +0900 [thread overview]
Message-ID: <4ED73CFA.7050308@nvidia.com> (raw)
In-Reply-To: <1322704074.11560.3.camel@phoenix>
Acked-by: Jin Park <jinyoungp@nvidia.com>
On 2011-12-01 오전 10:47, Axel Lin wrote:
> Use gpio_request_one() instead of multiple gpiolib calls.
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
> ---
> drivers/mfd/aat2870-core.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/aat2870-core.c b/drivers/mfd/aat2870-core.c
> index 02c4201..7620617 100644
> --- a/drivers/mfd/aat2870-core.c
> +++ b/drivers/mfd/aat2870-core.c
> @@ -407,13 +407,13 @@ static int aat2870_i2c_probe(struct i2c_client *client,
> aat2870->init(aat2870);
>
> if (aat2870->en_pin>= 0) {
> - ret = gpio_request(aat2870->en_pin, "aat2870-en");
> + ret = gpio_request_one(aat2870->en_pin, GPIOF_OUT_INIT_HIGH,
> + "aat2870-en");
> if (ret< 0) {
> dev_err(&client->dev,
> "Failed to request GPIO %d\n", aat2870->en_pin);
> goto out_kfree;
> }
> - gpio_direction_output(aat2870->en_pin, 1);
> }
>
> aat2870_enable(aat2870);
next prev parent reply other threads:[~2011-12-01 8:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 1:47 [PATCH 1/4] mfd: aat2870-core: Use gpio_request_one Axel Lin
2011-12-01 1:49 ` [PATCH 2/4] mfd: dm355evm_msp: " Axel Lin
2011-12-01 1:53 ` [PATCH 3/4] mfd: omap-usb-host: " Axel Lin
2011-12-01 8:02 ` Igor Grinberg
2011-12-01 1:55 ` [PATCH 4/4] mfd: twl6040-core: " Axel Lin
2011-12-01 8:02 ` Igor Grinberg
2011-12-01 8:18 ` Axel Lin
2011-12-01 9:10 ` Igor Grinberg
2011-12-01 8:38 ` Jinyoung Park [this message]
2011-12-19 11:13 ` [PATCH 1/4] mfd: aat2870-core: " Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED73CFA.7050308@nvidia.com \
--to=jinyoungp@nvidia.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox