* [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma
@ 2012-05-23 11:17 Tushar Behera
2012-05-24 4:24 ` Tushar Behera
2012-06-07 8:13 ` Vinod Koul
0 siblings, 2 replies; 6+ messages in thread
From: Tushar Behera @ 2012-05-23 11:17 UTC (permalink / raw)
To: linux-kernel; +Cc: vinod.koul, dan.j.williams, patches
Commit eab215855803 ("dmaengine: pl330: dont complete descriptor for
cyclic dma") wrongly completes descriptor for cyclic dma, hence following
BUG_ON is still hit with cyclic DMA operations.
kernel BUG at drivers/dma/dmaengine.h:53!
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
drivers/dma/pl330.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index fa3fb21..8c44f17 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2322,7 +2322,7 @@ static void pl330_tasklet(unsigned long data)
/* Pick up ripe tomatoes */
list_for_each_entry_safe(desc, _dt, &pch->work_list, node)
if (desc->status == DONE) {
- if (pch->cyclic)
+ if (!pch->cyclic)
dma_cookie_complete(&desc->txd);
list_move_tail(&desc->node, &list);
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma
2012-05-23 11:17 [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma Tushar Behera
@ 2012-05-24 4:24 ` Tushar Behera
2012-05-24 5:04 ` Jassi Brar
2012-06-07 8:13 ` Vinod Koul
1 sibling, 1 reply; 6+ messages in thread
From: Tushar Behera @ 2012-05-24 4:24 UTC (permalink / raw)
To: linux-kernel; +Cc: vinod.koul, dan.j.williams, patches, Jassi Brar
Forgot to add driver author in the original mail, adding now.
On 05/23/2012 04:47 PM, Tushar Behera wrote:
> Commit eab215855803 ("dmaengine: pl330: dont complete descriptor for
> cyclic dma") wrongly completes descriptor for cyclic dma, hence following
> BUG_ON is still hit with cyclic DMA operations.
>
> kernel BUG at drivers/dma/dmaengine.h:53!
>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> drivers/dma/pl330.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index fa3fb21..8c44f17 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2322,7 +2322,7 @@ static void pl330_tasklet(unsigned long data)
> /* Pick up ripe tomatoes */
> list_for_each_entry_safe(desc, _dt, &pch->work_list, node)
> if (desc->status == DONE) {
> - if (pch->cyclic)
> + if (!pch->cyclic)
> dma_cookie_complete(&desc->txd);
> list_move_tail(&desc->node, &list);
> }
--
Tushar Behera
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma
2012-05-24 4:24 ` Tushar Behera
@ 2012-05-24 5:04 ` Jassi Brar
2012-05-25 7:56 ` Vinod Koul
0 siblings, 1 reply; 6+ messages in thread
From: Jassi Brar @ 2012-05-24 5:04 UTC (permalink / raw)
To: Tushar Behera
Cc: linux-kernel, vinod.koul, dan.j.williams, patches, Thomas Abraham
On 24 May 2012 09:54, Tushar Behera <tushar.behera@linaro.org> wrote:
> Forgot to add driver author in the original mail, adding now.
>
> On 05/23/2012 04:47 PM, Tushar Behera wrote:
>> Commit eab215855803 ("dmaengine: pl330: dont complete descriptor for
>> cyclic dma") wrongly completes descriptor for cyclic dma, hence following
>> BUG_ON is still hit with cyclic DMA operations.
>>
>> kernel BUG at drivers/dma/dmaengine.h:53!
>>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> ---
>> drivers/dma/pl330.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
>> index fa3fb21..8c44f17 100644
>> --- a/drivers/dma/pl330.c
>> +++ b/drivers/dma/pl330.c
>> @@ -2322,7 +2322,7 @@ static void pl330_tasklet(unsigned long data)
>> /* Pick up ripe tomatoes */
>> list_for_each_entry_safe(desc, _dt, &pch->work_list, node)
>> if (desc->status == DONE) {
>> - if (pch->cyclic)
>> + if (!pch->cyclic)
>> dma_cookie_complete(&desc->txd);
>> list_move_tail(&desc->node, &list);
>> }
>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Obviously a typo, but the commit eab2158 had a tested-by, so I hope
this doesn't break something else.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma
2012-05-24 5:04 ` Jassi Brar
@ 2012-05-25 7:56 ` Vinod Koul
2012-05-25 8:31 ` Thomas Abraham
0 siblings, 1 reply; 6+ messages in thread
From: Vinod Koul @ 2012-05-25 7:56 UTC (permalink / raw)
To: Jassi Brar, 'Thomas Abraham'
Cc: Tushar Behera, linux-kernel, dan.j.williams, patches,
Thomas Abraham
On Thu, 2012-05-24 at 10:34 +0530, Jassi Brar wrote:
> On 24 May 2012 09:54, Tushar Behera <tushar.behera@linaro.org> wrote:
> > Forgot to add driver author in the original mail, adding now.
> >
> > On 05/23/2012 04:47 PM, Tushar Behera wrote:
> >> Commit eab215855803 ("dmaengine: pl330: dont complete descriptor for
> >> cyclic dma") wrongly completes descriptor for cyclic dma, hence following
> >> BUG_ON is still hit with cyclic DMA operations.
> >>
> >> kernel BUG at drivers/dma/dmaengine.h:53!
> >>
> >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> >> ---
> >> drivers/dma/pl330.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> >> index fa3fb21..8c44f17 100644
> >> --- a/drivers/dma/pl330.c
> >> +++ b/drivers/dma/pl330.c
> >> @@ -2322,7 +2322,7 @@ static void pl330_tasklet(unsigned long data)
> >> /* Pick up ripe tomatoes */
> >> list_for_each_entry_safe(desc, _dt, &pch->work_list, node)
> >> if (desc->status == DONE) {
> >> - if (pch->cyclic)
> >> + if (!pch->cyclic)
> >> dma_cookie_complete(&desc->txd);
> >> list_move_tail(&desc->node, &list);
> >> }
> >
> Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
>
> Obviously a typo, but the commit eab2158 had a tested-by, so I hope
> this doesn't break something else.
Precisely my worry as well. Thomas?
>From the code this looks as the right one.
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma
2012-05-25 7:56 ` Vinod Koul
@ 2012-05-25 8:31 ` Thomas Abraham
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Abraham @ 2012-05-25 8:31 UTC (permalink / raw)
To: Vinod Koul
Cc: Jassi Brar, Tushar Behera, linux-kernel, dan.j.williams, patches
On 25 May 2012 13:26, Vinod Koul <vinod.koul@linux.intel.com> wrote:
> On Thu, 2012-05-24 at 10:34 +0530, Jassi Brar wrote:
>> On 24 May 2012 09:54, Tushar Behera <tushar.behera@linaro.org> wrote:
>> > Forgot to add driver author in the original mail, adding now.
>> >
>> > On 05/23/2012 04:47 PM, Tushar Behera wrote:
>> >> Commit eab215855803 ("dmaengine: pl330: dont complete descriptor for
>> >> cyclic dma") wrongly completes descriptor for cyclic dma, hence following
>> >> BUG_ON is still hit with cyclic DMA operations.
>> >>
>> >> kernel BUG at drivers/dma/dmaengine.h:53!
>> >>
>> >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> >> ---
>> >> drivers/dma/pl330.c | 2 +-
>> >> 1 files changed, 1 insertions(+), 1 deletions(-)
>> >>
>> >> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
>> >> index fa3fb21..8c44f17 100644
>> >> --- a/drivers/dma/pl330.c
>> >> +++ b/drivers/dma/pl330.c
>> >> @@ -2322,7 +2322,7 @@ static void pl330_tasklet(unsigned long data)
>> >> /* Pick up ripe tomatoes */
>> >> list_for_each_entry_safe(desc, _dt, &pch->work_list, node)
>> >> if (desc->status == DONE) {
>> >> - if (pch->cyclic)
>> >> + if (!pch->cyclic)
>> >> dma_cookie_complete(&desc->txd);
>> >> list_move_tail(&desc->node, &list);
>> >> }
>> >
>> Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
>>
>> Obviously a typo, but the commit eab2158 had a tested-by, so I hope
>> this doesn't break something else.
> Precisely my worry as well. Thomas?
I am not sure what I have missed here. Since it was a simple change, I
think I manually edited the code for the test. I apologize for the
mistake in the test.
Regards,
Thomas.
>
> >From the code this looks as the right one.
>
> --
> ~Vinod
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma
2012-05-23 11:17 [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma Tushar Behera
2012-05-24 4:24 ` Tushar Behera
@ 2012-06-07 8:13 ` Vinod Koul
1 sibling, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2012-06-07 8:13 UTC (permalink / raw)
To: Tushar Behera; +Cc: linux-kernel, dan.j.williams, patches, stable
On Wed, 2012-05-23 at 16:47 +0530, Tushar Behera wrote:
> Commit eab215855803 ("dmaengine: pl330: dont complete descriptor for
> cyclic dma") wrongly completes descriptor for cyclic dma, hence following
> BUG_ON is still hit with cyclic DMA operations.
>
> kernel BUG at drivers/dma/dmaengine.h:53!
>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> drivers/dma/pl330.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index fa3fb21..8c44f17 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2322,7 +2322,7 @@ static void pl330_tasklet(unsigned long data)
> /* Pick up ripe tomatoes */
> list_for_each_entry_safe(desc, _dt, &pch->work_list, node)
> if (desc->status == DONE) {
> - if (pch->cyclic)
> + if (!pch->cyclic)
> dma_cookie_complete(&desc->txd);
> list_move_tail(&desc->node, &list);
> }
Applied thanks. I have cc'ed stable.
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-07 8:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-23 11:17 [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma Tushar Behera
2012-05-24 4:24 ` Tushar Behera
2012-05-24 5:04 ` Jassi Brar
2012-05-25 7:56 ` Vinod Koul
2012-05-25 8:31 ` Thomas Abraham
2012-06-07 8:13 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox