* [PATCH] Docs/admin-guide/cgroup-v2: add missing npn tags to zswap stats
@ 2026-11-17 6:26 Yu Miao
2026-11-17 21:20 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Yu Miao @ 2026-11-17 6:26 UTC (permalink / raw)
To: cgroups, tj, hannes, mkoutny, corbet, skhan, rdunlap, linux-doc,
linux-kernel
Cc: jiayuan.chen, nphamcs, Yu Miao
The zswap, zswapped and zswap_incomp entries never show up in
memory.numa_stat, so add the 'npn' tag to all three. Also move
zswap_incomp, currently listed between the zswpwb and thp_fault_alloc
counters, next to the zswap and zswapped entries it belongs with.
Signed-off-by: Yu Miao <yumiao@kylinos.cn>
---
Documentation/admin-guide/cgroup-v2.rst | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 9e3c67b02ae2..3f698f109d89 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1608,12 +1608,18 @@ The following nested keys are defined.
Amount of cached filesystem data that is swap-backed,
such as tmpfs, shm segments, shared anonymous mmap()s
- zswap
+ zswap (npn)
Amount of memory consumed by the zswap compression backend.
- zswapped
+ zswapped (npn)
Amount of application memory swapped out to zswap.
+ zswap_incomp (npn)
+ Amount of memory used by incompressible pages currently
+ stored in zswap without compression. These pages could not
+ be compressed to a size smaller than PAGE_SIZE, so they are
+ stored as-is.
+
file_mapped
Amount of cached filesystem data mapped with mmap(). Note
that some kernel configurations might account complete
@@ -1765,11 +1771,6 @@ The following nested keys are defined.
zswpwb
Number of pages written from zswap to swap.
- zswap_incomp
- Amount of memory used by incompressible pages currently stored in zswap
- without compression. These pages could not be compressed to
- a size smaller than PAGE_SIZE, so they are stored as-is.
-
thp_fault_alloc (npn)
Number of transparent hugepages which were allocated to satisfy
a page fault. This counter is not present when CONFIG_TRANSPARENT_HUGEPAGE
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Docs/admin-guide/cgroup-v2: add missing npn tags to zswap stats
2026-11-17 6:26 [PATCH] Docs/admin-guide/cgroup-v2: add missing npn tags to zswap stats Yu Miao
@ 2026-11-17 21:20 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2026-11-17 21:20 UTC (permalink / raw)
To: Yu Miao
Cc: cgroups, hannes, mkoutny, corbet, skhan, rdunlap, linux-doc,
linux-kernel, jiayuan.chen, nphamcs
Hello,
On Tue, Nov 17, 2026 at 02:26:20PM +0800, Yu Miao wrote:
> The zswap, zswapped and zswap_incomp entries never show up in
> memory.numa_stat, so add the 'npn' tag to all three.
The npn tags are off in other places too. Can you fix them all while at
it?
- swpin_zero, swpout_zero, zswpin, zswpout and zswpwb aren't in
memory.numa_stat either and are missing the tag.
- pgscan_{kswapd,direct,khugepaged,proactive}, the matching pgsteal_*
and pgrefill are in memory.numa_stat since e4f4fc7aa8b7 ("mm: move
pgscan, pgsteal, pgrefill to node stats") and shouldn't carry the tag
anymore. The pgscan and pgsteal totals are still npn.
Also, this should go through -mm. Can you please cc Andrew Morton
<akpm@linux-foundation.org> and linux-mm@kvack.org when reposting?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-17 21:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 6:26 [PATCH] Docs/admin-guide/cgroup-v2: add missing npn tags to zswap stats Yu Miao
2026-11-17 21:20 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox