From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used
Date: Thu, 3 Sep 2020 21:00:13 -0700 [thread overview]
Message-ID: <4cf621da-c917-bd4c-6d30-e8f145a24628@gmail.com> (raw)
In-Reply-To: <20200903220300.GH3112546@lunn.ch>
On 9/3/2020 3:03 PM, Andrew Lunn wrote:
>> The firmware provides the Device Tree but here is the relevant section for
>> you pasted below. The problematic device is a particular revision of the
>> silicon (D0) which got later fixed (E0) however the Device Tree was created
>> after the fixed platform, not the problematic one. Both revisions of the
>> silicon are in production.
>>
>> There should have been an internal MDIO bus created for that chip revision
>> such that we could have correctly parented phy@0 (bcm53125 below) as child
>> node of the internal MDIO bus, but you have to realize that this was done
>> back in 2014 when DSA was barely revived as an active subsystem. The
>> BCM53125 node should have have been converted to an actual switch node at
>> some point, I use a mdio_boardinfo overlay downstream to support the switch
>> as a proper b53/DSA switch, anyway.
>
> I was expecting something like that. I think this patch needs a
> comment in the code explaining it is a workaround for a DT blob which
> cannot be changed. Maybe also make it conditional on the board
> compatible string?
It is already targeted at the Broadcom pseudo PHY address (30) which is
the one that needs diversion, I will update the patch description
accordingly though.
--
Florian
next prev parent reply other threads:[~2020-09-04 4:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 21:03 [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used Florian Fainelli
2020-09-02 23:27 ` kernel test robot
2020-09-03 1:13 ` Andrew Lunn
2020-09-03 1:54 ` Florian Fainelli
2020-09-03 22:03 ` Andrew Lunn
2020-09-04 4:00 ` Florian Fainelli [this message]
2020-09-04 13:35 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cf621da-c917-bd4c-6d30-e8f145a24628@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox