[PATCH -next] wifi: mt76: mt7925:: replace zero-length array with flexible-array member

[PATCH -next] wifi: mt76: mt7925:: replace zero-length array with flexible-array member

[Zhang Kunbo]

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1],
introduced in C99:

struct foo {
	int stuff;
	struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last, which is beneficial
to cultivate a high-quality code.[2]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Zhang Kunbo <zhangkunbo@huawei.com>
---
 drivers/net/wireless/mediatek/mt76/mt7925/mcu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
index 748ea6adbc6b..956d62062730 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
@@ -388,7 +388,7 @@ mt7925_mcu_tx_done_event(struct mt792x_dev *dev, struct sk_buff *skb)
 	struct mt7925_mcu_txs_event {
 		u8 ver;
 		u8 rsv[3];
-		u8 data[0];
+		u8 data[];
 	} __packed * txs;
 	struct tlv *tlv;
 	u32 tlv_len;
-- 
2.34.1

Re: [PATCH -next] wifi: mt76: mt7925:: replace zero-length array with flexible-array member

[zhangkunbo]

ping gently.

RE: [PATCH -next] wifi: mt76: mt7925:: replace zero-length array with flexible-array member

[Ping-Ke Shih]

zhangkunbo <zhangkunbo@huawei.com> wrote:
> 
> ping gently.
> 

Have you checked patchwork?
As patch state is new [1], I think maintainers who have new year holiday
don't miss it. 

[1] https://patchwork.kernel.org/project/linux-wireless/patch/20241218074552.3271542-1-zhangkunbo@huawei.com/