From: David Hildenbrand <david@redhat.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Peter Xu <peterx@redhat.com>, Jason Gunthorpe <jgg@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v1 1/3] selftests/mm: factor out detection of hugetlb page sizes into vm_util
Date: Thu, 1 Jun 2023 09:52:01 +0200 [thread overview]
Message-ID: <4dfd0f47-e1f7-1e9f-65e0-ee4881495be3@redhat.com> (raw)
In-Reply-To: <e49b5642-014b-4a95-9ba8-738bfd02b2ea@lucifer.local>
On 28.05.23 16:49, Lorenzo Stoakes wrote:
> On Fri, May 19, 2023 at 12:27:21PM +0200, David Hildenbrand wrote:
>> Let's factor detection out into vm_util, to be reused by a new test.
>>
>
> Bit of a nit as it's hardly vitally important, but perhaps worth mentioning
> that you also refactor the function to accept any array (this is a
> requirement rather than simply refactoring a thing but still :)
Well, the function used to, and still does accept an array. It's just a
more human-friendly way of expressing that.
If I have to resend the whole patchset, I can add a note "While at it,
make the function accept an array instead of a raw pointer.".
[...]
>
> Looks good to me,
>
> Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
>
Thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-06-01 7:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 10:27 [PATCH v1 0/3] selftests/mm: new test for FOLL_LONGTERM on file mappings David Hildenbrand
2023-05-19 10:27 ` [PATCH v1 1/3] selftests/mm: factor out detection of hugetlb page sizes into vm_util David Hildenbrand
2023-05-28 14:49 ` Lorenzo Stoakes
2023-06-01 7:52 ` David Hildenbrand [this message]
2023-05-19 10:27 ` [PATCH v1 2/3] selftests/mm: gup_longterm: new functional test for FOLL_LONGTERM David Hildenbrand
2023-05-28 15:03 ` Lorenzo Stoakes
2023-06-01 8:16 ` David Hildenbrand
2023-06-01 21:41 ` Lorenzo Stoakes
2023-06-06 6:23 ` John Hubbard
2023-06-06 7:10 ` David Hildenbrand
2023-06-07 2:42 ` Andrew Morton
2023-05-19 10:27 ` [PATCH v1 3/3] selftests/mm: gup_longterm: add liburing tests David Hildenbrand
2023-05-28 15:04 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dfd0f47-e1f7-1e9f-65e0-ee4881495be3@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox