* [PATCH] f2fs: fix to remove redundant SBI_NEED_FSCK flag set
@ 2024-05-27 11:12 Zhiguo Niu
2024-05-29 6:48 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Zhiguo Niu @ 2024-05-27 11:12 UTC (permalink / raw)
To: jaegeuk, chao
Cc: linux-f2fs-devel, linux-kernel, niuzhiguo84, zhiguo.niu, ke.wang
Subsequent f2fs_stop_checkpoint will set cp_err, so this
SBI_NEED_FSCK flag set action is invalid.
Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
---
fs/f2fs/gc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 20e2f98..ef667fe 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -1752,7 +1752,6 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi,
if (type != GET_SUM_TYPE((&sum->footer))) {
f2fs_err(sbi, "Inconsistent segment (%u) type [%d, %d] in SSA and SIT",
segno, type, GET_SUM_TYPE((&sum->footer)));
- set_sbi_flag(sbi, SBI_NEED_FSCK);
f2fs_stop_checkpoint(sbi, false,
STOP_CP_REASON_CORRUPTED_SUMMARY);
goto skip;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] f2fs: fix to remove redundant SBI_NEED_FSCK flag set
2024-05-27 11:12 [PATCH] f2fs: fix to remove redundant SBI_NEED_FSCK flag set Zhiguo Niu
@ 2024-05-29 6:48 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2024-05-29 6:48 UTC (permalink / raw)
To: Zhiguo Niu, jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, niuzhiguo84, ke.wang
On 2024/5/27 19:12, Zhiguo Niu wrote:
> Subsequent f2fs_stop_checkpoint will set cp_err, so this
> SBI_NEED_FSCK flag set action is invalid.
>
> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-29 6:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-27 11:12 [PATCH] f2fs: fix to remove redundant SBI_NEED_FSCK flag set Zhiguo Niu
2024-05-29 6:48 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox