From: "Alex G." <mr.nuke.me@gmail.com>
To: Sinan Kaya <okaya@codeaurora.org>, bhelgaas@google.com
Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com,
shyam_iyer@dell.com, keith.busch@intel.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: Check for PCIe downtraining conditions
Date: Fri, 1 Jun 2018 10:50:39 -0500 [thread overview]
Message-ID: <4ffb153a-c26e-8762-df86-9d84dc726fa4@gmail.com> (raw)
In-Reply-To: <321c6d7d-b8e6-9b8d-91e5-a4f748acaa8e@codeaurora.org>
On 06/01/2018 10:10 AM, Sinan Kaya wrote:
> On 6/1/2018 11:06 AM, Alex G. wrote:
>> On 06/01/2018 10:03 AM, Sinan Kaya wrote:
>>> On 6/1/2018 11:01 AM, Alexandru Gagniuc wrote:
>>>> + /* Multi-function PCIe share the same link/status. */
>>>> + if (PCI_FUNC(dev->devfn) != 0)
>>>> + return;
>>>
>>> How about virtual functions?
>>
>> I have almost no clue about those. Is your concern that we might end up
>> printing more than our fair share of link statuses?
>
> Yes, struct pci_dev also has a flag called is_virtfn that you should bail out
> here too.
Will be fixed in v3.
Thanks,
Alex
>>
>> Alex
>>
>>
>
>
next prev parent reply other threads:[~2018-06-01 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 15:01 [PATCH v2] PCI: Check for PCIe downtraining conditions Alexandru Gagniuc
2018-06-01 15:03 ` Sinan Kaya
2018-06-01 15:06 ` Alex G.
2018-06-01 15:10 ` Sinan Kaya
2018-06-01 15:50 ` Alex G. [this message]
2018-06-01 15:12 ` Andy Shevchenko
2018-06-01 15:29 ` Alex G.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ffb153a-c26e-8762-df86-9d84dc726fa4@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=shyam_iyer@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox