From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Baole Ni" <baolex.ni@intel.com>,
"Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Dave Airlie" <airlied@linux.ie>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Doug Anderson" <dianders@chromium.org>,
"Andrew Duggan" <aduggan@synaptics.com>,
"Kukjin Kim" <kgene@kernel.org>, "Borislav Petkov" <bp@alien8.de>,
dougthompson@xmission.com, chuansheng.liu@intel.com,
"Guenter Roeck" <linux@roeck-us.net>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 0244/1285] Replace numeric parameter like 0444 with macro
Date: Wed, 10 Aug 2016 15:45:30 +0200 [thread overview]
Message-ID: <5052478.g1CZhtD17T@wuerfel> (raw)
In-Reply-To: <CACRpkdZsgSfL9rwe-vU5S6nNy0weD3O3PZymUZQsvJhQTSjf=w@mail.gmail.com>
On Wednesday, August 10, 2016 3:02:05 PM CEST Linus Walleij wrote:
> On Tue, Aug 2, 2016 at 12:52 PM, Baole Ni <baolex.ni@intel.com> wrote:
>
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
> >
> > Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> > Signed-off-by: Baole Ni <baolex.ni@intel.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> I assume Wolfram will merge this.
I assume not, see http://lwn.net/Articles/696227/
Arnd
next prev parent reply other threads:[~2016-08-10 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:52 [PATCH 0244/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-10 13:02 ` Linus Walleij
2016-08-10 13:45 ` Arnd Bergmann [this message]
2016-08-10 13:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5052478.g1CZhtD17T@wuerfel \
--to=arnd@arndb.de \
--cc=aduggan@synaptics.com \
--cc=airlied@linux.ie \
--cc=baolex.ni@intel.com \
--cc=bp@alien8.de \
--cc=chuansheng.liu@intel.com \
--cc=dianders@chromium.org \
--cc=dougthompson@xmission.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox