* [PATCH v2] rtc: tps65910: Use platform_get_irq to get RTC irq details
@ 2012-09-25 5:29 Venu Byravarasu
2012-09-25 6:21 ` Stephen Warren
0 siblings, 1 reply; 3+ messages in thread
From: Venu Byravarasu @ 2012-09-25 5:29 UTC (permalink / raw)
To: akpm, swarren, a.zummo; +Cc: linux-kernel, rtc-linux, Venu Byravarasu
As RTC driver needs only irq number from platform data,
using platform_get_irq(), instead of generic dev_get_platdata().
Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
---
delta from v1:
Removed unrelated clean up done in the RTC driver, with patch #1.
drivers/rtc/rtc-tps65910.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-tps65910.c b/drivers/rtc/rtc-tps65910.c
index 691ab96..2290508 100644
--- a/drivers/rtc/rtc-tps65910.c
+++ b/drivers/rtc/rtc-tps65910.c
@@ -226,7 +226,6 @@ static int __devinit tps65910_rtc_probe(struct platform_device *pdev)
{
struct tps65910 *tps65910 = NULL;
struct tps65910_rtc *tps_rtc = NULL;
- struct tps65910_board *pmic_plat_data;
int ret;
int irq;
u32 rtc_reg;
@@ -253,15 +252,13 @@ static int __devinit tps65910_rtc_probe(struct platform_device *pdev)
if (ret < 0)
return ret;
- pmic_plat_data = dev_get_platdata(tps65910->dev);
- irq = pmic_plat_data->irq_base;
+ irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
dev_warn(&pdev->dev, "Wake up is not possible as irq = %d\n",
irq);
return ret;
}
- irq += TPS65910_IRQ_RTC_ALARM;
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
tps65910_rtc_interrupt, IRQF_TRIGGER_LOW,
"rtc-tps65910", &pdev->dev);
--
1.7.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rtc: tps65910: Use platform_get_irq to get RTC irq details
2012-09-25 5:29 [PATCH v2] rtc: tps65910: Use platform_get_irq to get RTC irq details Venu Byravarasu
@ 2012-09-25 6:21 ` Stephen Warren
2012-09-25 6:58 ` Venu Byravarasu
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Warren @ 2012-09-25 6:21 UTC (permalink / raw)
To: Venu Byravarasu; +Cc: akpm, a.zummo, linux-kernel, rtc-linux
On 09/24/2012 11:29 PM, Venu Byravarasu wrote:
> As RTC driver needs only irq number from platform data,
> using platform_get_irq(), instead of generic dev_get_platdata().
This seems fine to me now.
However, it'd be useful to post all the patches related to this issue at
one time, so we can get a clear picture of everything that goes into
fixing the problem.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v2] rtc: tps65910: Use platform_get_irq to get RTC irq details
2012-09-25 6:21 ` Stephen Warren
@ 2012-09-25 6:58 ` Venu Byravarasu
0 siblings, 0 replies; 3+ messages in thread
From: Venu Byravarasu @ 2012-09-25 6:58 UTC (permalink / raw)
To: Stephen Warren
Cc: akpm@linux-foundation.org, a.zummo@towertech.it,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com
> -----Original Message-----
> From: Stephen Warren [mailto:swarren@wwwdotorg.org]
> Sent: Tuesday, September 25, 2012 11:51 AM
> To: Venu Byravarasu
> Cc: akpm@linux-foundation.org; a.zummo@towertech.it; linux-
> kernel@vger.kernel.org; rtc-linux@googlegroups.com
> Subject: Re: [PATCH v2] rtc: tps65910: Use platform_get_irq to get RTC irq
> details
>
> On 09/24/2012 11:29 PM, Venu Byravarasu wrote:
> > As RTC driver needs only irq number from platform data,
> > using platform_get_irq(), instead of generic dev_get_platdata().
>
> This seems fine to me now.
>
> However, it'd be useful to post all the patches related to this issue at
> one time, so we can get a clear picture of everything that goes into
> fixing the problem.
Sure Stephen.
Will push mfd patches soon.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-25 6:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-25 5:29 [PATCH v2] rtc: tps65910: Use platform_get_irq to get RTC irq details Venu Byravarasu
2012-09-25 6:21 ` Stephen Warren
2012-09-25 6:58 ` Venu Byravarasu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox